| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130621062111.GC10873@elgon.mountain> Date: Fri, 21 Jun 2013 09:21:11 +0300 From: Dan Carpenter <dan.carpenter@...cle.com> To: Joshua Morris <josh.h.morris@...ibm.com> Cc: Philip Kelleher <pjk1939@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: [patch] rsxx: returning bytes remaining instead of -EFAULT copy_to/from_user() returns the number of bytes remaining to be copied. We should return -EFAULT here instead. Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com> diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c index 6e85e21..102dc60 100644 --- a/drivers/block/rsxx/core.c +++ b/drivers/block/rsxx/core.c @@ -199,9 +199,8 @@ static ssize_t rsxx_cram_read(struct file *fp, char __user *ubuf, if (st) return st; - st = copy_to_user(ubuf, buf, cnt); - if (st) - return st; + if (copy_to_user(ubuf, buf, cnt)) + return -EFAULT; info->offset += cnt; @@ -222,9 +221,8 @@ static ssize_t rsxx_cram_write(struct file *fp, const char __user *ubuf, if (!buf) return -ENOMEM; - st = copy_from_user(buf, ubuf, cnt); - if (st) - return st; + if (copy_from_user(buf, ubuf, cnt)) + return -EFAULT; info->f_pos = (u32)*ppos + info->offset; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists