linux-kernel - Re: [PATCH V2] dma: mmp_tdma: disable irq when disabling dma channel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130621085208.GE23141@intel.com>
Date:	Fri, 21 Jun 2013 14:22:08 +0530
From:	Vinod Koul <vinod.koul@...el.com>
To:	Qiao Zhou <zhouqiao@...vell.com>
Cc:	djbw@...com, zhangfei.gao@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] dma: mmp_tdma: disable irq when disabling dma
 channel

On Sat, Jun 15, 2013 at 12:51:48PM +0800, Qiao Zhou wrote:
> mask dma irq when disabling dma channel, so that interrupt status
> will not be set and interrupt won't come again.
> 
> Signed-off-by: Qiao Zhou <zhouqiao@...vell.com>
Applied, thanks

--
~Vinod
> ---
>  drivers/dma/mmp_tdma.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
> index 43d5a6c..9b93665 100644
> --- a/drivers/dma/mmp_tdma.c
> +++ b/drivers/dma/mmp_tdma.c
> @@ -154,6 +154,10 @@ static void mmp_tdma_disable_chan(struct mmp_tdma_chan *tdmac)
>  {
>  	writel(readl(tdmac->reg_base + TDCR) & ~TDCR_CHANEN,
>  					tdmac->reg_base + TDCR);
> +
> +	/* disable irq */
> +	writel(0, tdmac->reg_base + TDIMR);
> +
>  	tdmac->status = DMA_SUCCESS;
>  }
>  
> -- 
> 1.7.0.4
> 

-- 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/