linux-kernel - Re: [PATCH v12 08/11] spi: omap2-mcspi: add generic DMA request support to the DT binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51C42C77.90909@ti.com>
Date:	Fri, 21 Jun 2013 16:05:35 +0530
From:	Sourav Poddar <sourav.poddar@...com>
To:	Benoit Cousson <b-cousson@...com>
CC:	Joel A Fernandes <joelagnel@...com>,
	Tony Lindgren <tony@...mide.com>, Sekhar Nori <nsekhar@...com>,
	Matt Porter <matt@...orter.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Mark Brown <broonie@...nel.org>,
	Russell King <linux@....linux.org.uk>,
	Rob Landley <rob@...dley.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jason Kridner <jkridner@...gleboard.org>,
	Koen Kooi <koen@...gleboard.org>,
	Devicetree Discuss <devicetree-discuss@...ts.ozlabs.org>,
	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux DaVinci Kernel List 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Documentation List <linux-doc@...r.kernel.org>,
	Linux MMC List <linux-mmc@...r.kernel.org>,
	Linux SPI Devel List 
	<spi-devel-general@...ts.sourceforge.net>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v12 08/11] spi: omap2-mcspi: add generic DMA request support
 to the DT binding

Hi Benoit,
On Friday 21 June 2013 02:36 AM, Joel A Fernandes wrote:
> From: Matt Porter<mporter@...com>
>
> The binding definition is based on the generic DMA request binding
>
> Signed-off-by: Matt Porter<mporter@...com>
> Signed-off-by: Joel A Fernandes<joelagnel@...com>
> ---
>   Documentation/devicetree/bindings/spi/omap-spi.txt |   27 +++++++++++++++++++-
>   1 file changed, 26 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/spi/omap-spi.txt b/Documentation/devicetree/bindings/spi/omap-spi.txt
> index 938809c..4c85c4c 100644
> --- a/Documentation/devicetree/bindings/spi/omap-spi.txt
> +++ b/Documentation/devicetree/bindings/spi/omap-spi.txt
> @@ -10,7 +10,18 @@ Required properties:
>   			  input. The default is D0 as input and
>   			  D1 as output.
>
> -Example:
> +Optional properties:
> +- dmas: List of DMA specifiers with the controller specific format
> +	as described in the generic DMA client binding. A tx and rx
> +	specifier is required for each chip select.
> +- dma-names: List of DMA request names. These strings correspond
> +	1:1 with the DMA specifiers listed in dmas. The string naming
> +	is to be "rxN" and "txN" for RX and TX requests,
> +	respectively, where N equals the chip select number.
> +
> +Examples:
> +
> +[hwmod populated DMA resources]
>
>   mcspi1: mcspi@1 {
>       #address-cells =<1>;
> @@ -20,3 +31,17 @@ mcspi1: mcspi@1 {
>       ti,spi-num-cs =<4>;
>   };
>
> +[generic DMA request binding]
> +
> +mcspi1: mcspi@1 {
> +    #address-cells =<1>;
> +    #size-cells =<0>;
> +    compatible = "ti,omap4-mcspi";
> +    ti,hwmods = "mcspi1";
> +    ti,spi-num-cs =<2>;
> +    dmas =<&edma 42
> +	&edma 43
> +	&edma 44
> +	&edma 45>;
> +    dma-names = "tx0", "rx0", "tx1", "rx1";
> +};
If the patch looks good to you, these can go independently in your
tree.

Reviewed-by: Sourav Poddar <sourav.poddar@...com>

~Sourav

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/