lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 21 Jun 2013 12:46:31 +0100 From: "Jan Beulich" <JBeulich@...e.com> To: "Roger Pau Monne" <roger.pau@...rix.com> Cc: <xen-devel@...ts.xen.org>, "Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>, <linux-kernel@...r.kernel.org> Subject: Re: [Xen-devel] [PATCH 3/4] xen-blkback: check the number of iovecs before allocating a bios >>> On 21.06.13 at 12:56, Roger Pau Monne <roger.pau@...rix.com> wrote: > @@ -1236,7 +1236,8 @@ static int dispatch_rw_block_io(struct xen_blkif *blkif, > seg[i].nsec << 9, > seg[i].offset) == 0)) { > > - bio = bio_alloc(GFP_KERNEL, nseg-i); > + int nr_iovecs = (nseg-i) > BIO_MAX_PAGES ? BIO_MAX_PAGES : (nseg-i); I'm sure this results in a compiler warning (declaration after statement). And it surely would read much better if you used some form of min() - the shorter line would at once allow you to properly blank separate operands from operators. Jan > + bio = bio_alloc(GFP_KERNEL, nr_iovecs); > if (unlikely(bio == NULL)) > goto fail_put_bio; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists