linux-kernel - Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130621115746.GA5142@infradead.org>
Date:	Fri, 21 Jun 2013 04:57:46 -0700
From:	Christoph Hellwig <hch@...radead.org>
To:	Paolo Bonzini <pbonzini@...hat.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Tejun Heo <tj@...nel.org>, Jens Axboe <axboe@...nel.dk>,
	lkml <linux-kernel@...r.kernel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	asias.hejun@...il.com
Subject: Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization
 of the SG_IO command whitelist (CVE-2012-4542))

On Sat, May 25, 2013 at 09:05:25AM +0200, Paolo Bonzini wrote:
> Linus wanted to keep that for CAP_SYS_RAWIO.  We found two uses of SG_IO
> on partitions: zfs-fuse used SYNCHRONIZE CACHE; some proprietary driver
> used TEST UNIT READY.

FYI I looked at the zfs code and the way it uses it is part of a huge
braindamage.

Given that the upstream appears dead I've Cc'd Asias He as he appears
to somehow maintain it as part of the Debian package.

Asias,

the flushwc() routine in zfs-fuse is overly complicated and will not do
the right thing for many cases like using device mapper, many modern SSD
device, or much simple file backed filesystems.

Fortunately fixing this is trivial - the call to flushwc can be replaced
with a call to fdatasync() and the the kernel will do the right thing
for any backing device or file.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/