linux-kernel - Re: [PATCH char-misc-next] UIO: Fix concurrency issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130621124431.GA11224@amd.pavel.ucw.cz>
Date:	Fri, 21 Jun 2013 14:44:32 +0200
From:	Pavel Machek <pavel@....cz>
To:	Vitalii Demianets <vitas@...factor.kiev.ua>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Hans J. Koch" <hjk@...sjkoch.de>
Subject: Re: [PATCH char-misc-next] UIO: Fix concurrency issue

On Thu 2013-06-20 16:36:00, Vitalii Demianets wrote:
> In a SMP case there was a race condition issue between 
> uio_pdrv_genirq_irqcontrol() running on one CPU and irq handler on another 
> CPU. Fix it by spin_locking shared resources access inside irq handler.
> Also:
>   - Change disable_irq to disable_irq_nosync to avoid deadlock, because 
> disable_irq waits for the completion of the irq handler;
>   - Change atomic bit-manipulation routines to their non-atomic counterparts 
> as we already are guarding the code by spinlock.
> 
> Signed-off-by: Vitalii Demianets <vitas@...factor.kiev.ua>

Sounds good.

Reviewed-by: Pavel Machek <pavel@....cz>

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/