linux-kernel - Re: [PATCH -next] rsxx: fix error return code in rsxx_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130621140551.GO6492@oc6784271780.ibm.com>
Date:	Fri, 21 Jun 2013 09:05:51 -0500
From:	"Philip J. Kelleher" <pjk1939@...ux.vnet.ibm.com>
To:	Wei Yongjun <weiyj.lk@...il.com>
Cc:	josh.h.morris@...ibm.com, axboe@...nel.dk,
	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] rsxx: fix error return code in rsxx_pci_probe()

On Fri, Jun 21, 2013 at 10:46:38AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> Fix to return -ENOMEM in the create_singlethread_workqueue() error handling
> case instead of 0, as done elsewhere in this function.
> 
> Introduced by commit a3299ab18591d36ad5622f5064619123c439b779.
> (rsxx: Individual workqueues for interruptible events.)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>  drivers/block/rsxx/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
> index 6e85e21..11eb897 100644
> --- a/drivers/block/rsxx/core.c
> +++ b/drivers/block/rsxx/core.c
> @@ -946,6 +946,7 @@ static int rsxx_pci_probe(struct pci_dev *dev,
>  	card->event_wq = create_singlethread_workqueue(DRIVER_NAME"_event");
>  	if (!card->event_wq) {
>  		dev_err(CARD_TO_DEV(card), "Failed card event setup.\n");
> +		st = -ENOMEM;
>  		goto failed_event_handler;
>  	}

Thank You for fixing that.

> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/