linux-kernel - Re: [PATCH v2 3/3] mfd: max8998: Add support for Device Tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130621143745.GV27646@sirena.org.uk>
Date:	Fri, 21 Jun 2013 15:37:45 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Tomasz Figa <t.figa@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Kukjin Kim <kgene.kim@...sung.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Grant Likely <grant.likely@...aro.org>,
	Jiri Kosina <jkosina@...e.cz>,
	Liam Girdwood <lgirdwood@...il.com>,
	Masanari Iida <standby24x7@...il.com>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>, rtc-linux@...glegroups.com,
	Russell King <linux@....linux.org.uk>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Kyungmin Park <kyungmin.park@...sung.com>
Subject: Re: [PATCH v2 3/3] mfd: max8998: Add support for Device Tree

On Fri, Jun 21, 2013 at 02:33:37PM +0200, Tomasz Figa wrote:

> +	- EN32KHz AP: 32KHz clock output for application processor
> +	- EN32KHz CP: 32KHz clock output for call processor

The clocks should be supported using the clock API not the regulator
API, they shouldn't be present in the DT regulator binding.

> +	if (iodev->dev->of_node) {
> +		ret = max8998_pmic_dt_parse_pdata(iodev, pdata);
> +		if (ret)
> +			return ret;
> +	}
> +

Might be neater to have the check inside the function?

>  		if (IS_ERR(rdev[i])) {
>  			ret = PTR_ERR(rdev[i]);
> -			dev_err(max8998->dev, "regulator init failed\n");
> +			dev_err(max8998->dev, "regulator %s init failed\n",
> +							regulators[index].name);

Print the error code (the original doesn't but since you're changing
it...)?

> index 46f2301..042a873 100644
> --- a/drivers/rtc/rtc-max8998.c
> +++ b/drivers/rtc/rtc-max8998.c
> @@ -253,7 +253,7 @@ static const struct rtc_class_ops max8998_rtc_ops = {
>  static int max8998_rtc_probe(struct platform_device *pdev)
>  {
>  	struct max8998_dev *max8998 = dev_get_drvdata(pdev->dev.parent);
> -	struct max8998_platform_data *pdata = dev_get_platdata(max8998->dev);
> +	struct max8998_platform_data *pdata = max8998->pdata;
>  	struct max8998_rtc_info *info;
>  	int ret;
>  

Probably better to split out this refactoring into a separate patch.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)