[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1371825813.19215.34.camel@joe-AO722>
Date: Fri, 21 Jun 2013 07:43:33 -0700
From: Joe Perches <joe@...ches.com>
To: Alexey Brodkin <Alexey.Brodkin@...opsys.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
Andy Shevchenko <andy.shevchenko@...il.com>,
Francois Romieu <romieu@...zoreil.com>,
Vineet Gupta <Vineet.Gupta1@...opsys.com>,
Mischa Jonker <Mischa.Jonker@...opsys.com>,
Arnd Bergmann <arnd@...db.de>,
Grant Likely <grant.likely@...aro.org>,
Rob Herring <rob.herring@...xeda.com>,
Paul Gortmaker <paul.gortmaker@...driver.com>,
"David S. Miller" <davem@...emloft.net>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"devicetree-discuss@...ts.ozlabs.org"
<devicetree-discuss@...ts.ozlabs.org>,
Florian Fainelli <florian@...nwrt.org>
Subject: Re: [PATCH v7] ethernet/arc/arc_emac - Add new driver
On Fri, 2013-06-21 at 10:53 +0000, Alexey Brodkin wrote:
> On 06/21/2013 02:32 PM, Joe Perches wrote:
> > On Fri, 2013-06-21 at 11:20 +0400, Alexey Brodkin wrote:
> >> Driver for non-standard on-chip ethernet device ARC EMAC 10/100,
> >> instantiated in some legacy ARC (Synopsys) FPGA Boards such as
> >> ARCAngel4/ML50x.
[]
> >> + rxbd->data = (unsigned char *)cpu_to_le32(rx_buff->skb->data);
> >
> > 32 bit only. Should the Kconfig block have some arch_arc dependency
> > so it can't get compiled for 64 bit systems?
[]
> So for now I may easily add dependency on ARC if it makes acceptance of
> driver easier.
I don't think it's a big problem.
Maybe add a Kconfig "depends on !64BIT".
Another thing to do would be to run it through sparse
with make C=1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists