linux-kernel - Re: [PATCH V6 24/30] thermal: exynos: Add thermal configuration data for exynos5440 TMU sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CADGdYn4y4jR3X7dzUFjaSvFsh8WzdF7c5izJ10oYyaCEd+ioHQ@mail.gmail.com>
Date:	Fri, 21 Jun 2013 20:51:16 +0530
From:	amit daniel kachhap <amit.daniel@...sung.com>
To:	Eduardo Valentin <eduardo.valentin@...com>
Cc:	linux-pm@...r.kernel.org, Zhang Rui <rui.zhang@...el.com>,
	linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kukjin Kim <kgene.kim@...sung.com>, jonghwa3.lee@...sung.com
Subject: Re: [PATCH V6 24/30] thermal: exynos: Add thermal configuration data
 for exynos5440 TMU sensor

On Fri, Jun 21, 2013 at 8:49 PM, amit daniel kachhap
<amit.daniel@...sung.com> wrote:
> Hi,
>
> On Thu, Jun 20, 2013 at 7:48 AM, Eduardo Valentin
> <eduardo.valentin@...com> wrote:
>> On 17-06-2013 02:46, Amit Daniel Kachhap wrote:
>>> This patch adds configuration data for exynos5440 soc. Also register
>>> definations for the controller are added.
>>>
>>> Acked-by: Jonghwa Lee <jonghwa3.lee@...sung.com>
>>> Acked-by: Kukjin Kim <kgene.kim@...sung.com>
>>> Signed-off-by: Amit Daniel Kachhap <amit.daniel@...sung.com>
>>> ---
>>>  drivers/thermal/samsung/exynos_tmu.c      |    4 ++
>>>  drivers/thermal/samsung/exynos_tmu_data.c |   71 +++++++++++++++++++++++++++++
>>>  drivers/thermal/samsung/exynos_tmu_data.h |    7 +++
>>>  3 files changed, 82 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
>>> index db4035d..a4dbc84 100644
>>> --- a/drivers/thermal/samsung/exynos_tmu.c
>>> +++ b/drivers/thermal/samsung/exynos_tmu.c
>>> @@ -455,6 +455,10 @@ static const struct of_device_id exynos_tmu_match[] = {
>>>               .compatible = "samsung,exynos5250-tmu",
>>>               .data = (void *)EXYNOS5250_TMU_DRV_DATA,
>>>       },
>>> +     {
>>> +             .compatible = "samsung,exynos5440-tmu",
>>> +             .data = (void *)EXYNOS5440_TMU_DRV_DATA,
>>> +     },
>>>       {},
>>>  };
>>>  MODULE_DEVICE_TABLE(of, exynos_tmu_match);
>>> diff --git a/drivers/thermal/samsung/exynos_tmu_data.c b/drivers/thermal/samsung/exynos_tmu_data.c
>>> index 694557e..b34e726 100644
>>> --- a/drivers/thermal/samsung/exynos_tmu_data.c
>>> +++ b/drivers/thermal/samsung/exynos_tmu_data.c
>>> @@ -175,3 +175,74 @@ struct exynos_tmu_init_data const exynos5250_default_tmu_data = {
>>>       .tmu_count = 1,
>>>  };
>>>  #endif
>>> +
>>> +#if defined(CONFIG_SOC_EXYNOS5440)
>>> +static const struct exynos_tmu_registers exynos5440_tmu_registers = {
>>> +     .triminfo_data = EXYNOS5440_TMU_S0_7_TRIM,
>>> +     .triminfo_25_shift = EXYNOS_TRIMINFO_25_SHIFT,
>>> +     .triminfo_85_shift = EXYNOS_TRIMINFO_85_SHIFT,
>>> +     .tmu_ctrl = EXYNOS5440_TMU_S0_7_CTRL,
>>> +     .buf_vref_sel_shift = EXYNOS_TMU_REF_VOLTAGE_SHIFT,
>>> +     .buf_vref_sel_mask = EXYNOS_TMU_REF_VOLTAGE_MASK,
>>> +     .therm_trip_mode_shift = EXYNOS_TMU_TRIP_MODE_SHIFT,
>>> +     .therm_trip_mode_mask = EXYNOS_TMU_TRIP_MODE_MASK,
>>> +     .therm_trip_en_shift = EXYNOS_TMU_THERM_TRIP_EN_SHIFT,
>>> +     .buf_slope_sel_shift = EXYNOS_TMU_BUF_SLOPE_SEL_SHIFT,
>>> +     .buf_slope_sel_mask = EXYNOS_TMU_BUF_SLOPE_SEL_MASK,
>>> +     .core_en_shift = EXYNOS_TMU_CORE_EN_SHIFT,
>>> +     .tmu_status = EXYNOS5440_TMU_S0_7_STATUS,
>>> +     .tmu_cur_temp = EXYNOS5440_TMU_S0_7_TEMP,
>>> +     .threshold_th0 = EXYNOS5440_TMU_S0_7_TH0,
>>> +     .threshold_th1 = EXYNOS5440_TMU_S0_7_TH1,
>>> +     .threshold_th2 = EXYNOS5440_TMU_S0_7_TH2,
>>> +     .threshold_th3_l0_shift = EXYNOS5440_TMU_TH_RISE4_SHIFT,
>>> +     .tmu_inten = EXYNOS5440_TMU_S0_7_IRQEN,
>>> +     .inten_rise_mask = EXYNOS5440_TMU_RISE_INT_MASK,
>>> +     .inten_rise_shift = EXYNOS5440_TMU_RISE_INT_SHIFT,
>>> +     .inten_fall_mask = EXYNOS5440_TMU_FALL_INT_MASK,
>>> +     .inten_fall_shift = EXYNOS5440_TMU_FALL_INT_SHIFT,
>>> +     .inten_rise0_shift = EXYNOS5440_TMU_INTEN_RISE0_SHIFT,
>>> +     .inten_rise1_shift = EXYNOS5440_TMU_INTEN_RISE1_SHIFT,
>>> +     .inten_rise2_shift = EXYNOS5440_TMU_INTEN_RISE2_SHIFT,
>>> +     .inten_rise3_shift = EXYNOS5440_TMU_INTEN_RISE3_SHIFT,
>>> +     .inten_fall0_shift = EXYNOS5440_TMU_INTEN_FALL0_SHIFT,
>>> +     .tmu_intstat = EXYNOS5440_TMU_S0_7_IRQ,
>>> +     .tmu_intclear = EXYNOS5440_TMU_S0_7_IRQ,
>>> +     .tmu_irqstatus = EXYNOS5440_TMU_IRQ_STATUS,
>>> +     .emul_con = EXYNOS5440_TMU_S0_7_DEBUG,
>>> +     .emul_temp_shift = EXYNOS_EMUL_DATA_SHIFT,
>>> +     .tmu_pmin = EXYNOS5440_TMU_PMIN,
>>> +};
>>> +
>>> +#define EXYNOS5440_TMU_DATA \
>>> +     .trigger_levels[0] = 100, \
>>> +     .trigger_levels[4] = 105, \
>>> +     .trigger_enable[0] = 1, \
>>> +     .trigger_type[0] = SW_TRIP, \
>>> +     .trigger_type[4] = HW_TRIP, \
>>
>> No active / passive cooling?
>>
>>> +     .max_trigger_level = 5, \
>>> +     .gain = 5, \
>>> +     .reference_voltage = 16, \
>>> +     .noise_cancel_mode = 4, \
>>> +     .cal_type = TYPE_ONE_POINT_TRIMMING, \
>>> +     .cal_mode = 0, \
>>> +     .efuse_value = 0x5b2d, \
>>> +     .min_efuse_value = 16, \
>>> +     .max_efuse_value = 76, \
>>> +     .first_point_trim = 25, \
>>> +     .second_point_trim = 70, \
>>> +     .default_temp_offset = 25, \
>>> +     .type = SOC_ARCH_EXYNOS5440, \
>>> +     .registers = &exynos5440_tmu_registers, \
>>> +     .features = (TMU_SUPPORT_EMULATION | TMU_SUPPORT_FALLING_TRIP | \
>>> +                     TMU_SUPPORT_MULTI_INST | TMU_SUPPORT_SHARED_MEMORY),
>>
>> No freq table on 5440? hmm.. So no cpufreq_cooling then? Any reason why
>> not? I suppose one of these 3 sensors are on your CPU domain, right?
> In 5440 no cpufreq cooling is needed. Only sw trip and hw trip is sufficient.
Infact all sensors are cpu related at some positions.
>
> Thanks,
> Amit Daniel
>>
>>> +
>>> +struct exynos_tmu_init_data const exynos5440_default_tmu_data = {
>>> +     .tmu_data = {
>>> +             { EXYNOS5440_TMU_DATA } ,
>>> +             { EXYNOS5440_TMU_DATA } ,
>>> +             { EXYNOS5440_TMU_DATA } ,
>>> +     },
>>> +     .tmu_count = 3,
>>> +};
>>> +#endif
>>> diff --git a/drivers/thermal/samsung/exynos_tmu_data.h b/drivers/thermal/samsung/exynos_tmu_data.h
>>> index ad263e9..43ce5fb 100644
>>> --- a/drivers/thermal/samsung/exynos_tmu_data.h
>>> +++ b/drivers/thermal/samsung/exynos_tmu_data.h
>>> @@ -143,4 +143,11 @@ extern struct exynos_tmu_init_data const exynos5250_default_tmu_data;
>>>  #define EXYNOS5250_TMU_DRV_DATA (NULL)
>>>  #endif
>>>
>>> +#if defined(CONFIG_SOC_EXYNOS5440)
>>> +extern struct exynos_tmu_init_data const exynos5440_default_tmu_data;
>>> +#define EXYNOS5440_TMU_DRV_DATA (&exynos5440_default_tmu_data)
>>> +#else
>>> +#define EXYNOS5440_TMU_DRV_DATA (NULL)
>>> +#endif
>>> +
>>>  #endif /*_EXYNOS_TMU_DATA_H*/
>>>
>>
>>
>> --
>> You have got to be excited about what you are doing. (L. Lamport)
>>
>> Eduardo Valentin
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/