lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1371828346.3040.3.camel@dabdike>
Date:	Fri, 21 Jun 2013 08:25:46 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Aaron Lu <aaron.lu@...el.com>
Cc:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	Tejun Heo <tj@...nel.org>, Matthew Garrett <mjg@...hat.com>,
	Liu Jiang <liuj97@...il.com>,
	Dirk Griesbach <spamthis@...enet.de>,
	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org,
	Liu Jiang <jiang.liu@...wei.com>
Subject: Re: [PATCH] libata: remove dead code from libata-acpi.c

On Fri, 2013-06-21 at 08:55 +0800, Aaron Lu wrote:
> On 06/20/2013 07:02 PM, Sergei Shtylyov wrote:
> > Hello.
> 
> Hi,
> 
> Thanks for your comments.
> 
> > 
> > On 20-06-2013 6:26, Aaron Lu wrote:
> >>
> >> +void ata_acpi_hotplug_init(struct ata_host *host)
> >> +{
> >> +	int i;
> >> +
> >> +	for (i = 0; i < host->n_ports; i++) {
> >> +		struct ata_port *ap = host->ports[i];
> >> +		acpi_handle handle;
> >> +		struct ata_device *dev;
> >> +
> >> +		if (!ap)
> >> +			continue;
> >> +
> >> +		handle = ata_ap_acpi_handle(ap);
> >> +		if (handle) {
> >> +			/* we might be on a docking station */
> >> +			register_hotplug_dock_device(handle,
> >> +					&ata_acpi_ap_dock_ops, ap);
> > 
> >     Please indent this line under the next character after ( above.
> 
> Is there a link about this rule? I might have missed something about
> coding style.

The rule is follow the coding style in the file, unless there's
something really wrong with it (which there might be in the case of
really old drivers).  The reason is that a mixture of coding styles
makes the file much harder to read than a single consistent style.

In this case, if you look at libata-acpi.c you see all continuation
lines of function calls are aligned with open braces.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ