linux-kernel - Re: [PATCH v3] kernel/signal.c: fix BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130621161241.GC17626@linux-mips.org>
Date:	Fri, 21 Jun 2013 18:12:41 +0200
From:	Ralf Baechle <ralf@...ux-mips.org>
To:	David Daney <ddaney.cavm@...il.com>
Cc:	James Hogan <james.hogan@...tec.com>, linux-kernel@...r.kernel.org,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Kees Cook <keescook@...omium.org>,
	David Daney <david.daney@...ium.com>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	David Howells <dhowells@...hat.com>,
	Dave Jones <davej@...hat.com>, linux-mips@...ux-mips.org
Subject: Re: [PATCH v3] kernel/signal.c: fix BUG_ON with SIG128 (MIPS)

On Fri, Jun 21, 2013 at 08:59:32AM -0700, David Daney wrote:

> On 06/21/2013 06:39 AM, James Hogan wrote:
> >MIPS has 128 signals, the highest of which has the number 128 (they
> >start from 1). The following command causes get_signal_to_deliver() to
> >pass this signal number straight through to do_group_exit() as the exit
> >code:
> >
> >   strace sleep 10 & sleep 1 && kill -128 `pidof sleep`
> >
> >However do_group_exit() checks for the core dump bit (0x80) in the exit
> >code which matches in this particular case and the kernel panics:
> >
> >   BUG_ON(exit_code & 0x80); /* core dumps don't get here */
> >
> >Fundamentally the exit / wait status code cannot represent SIG128. In
> >fact it cannot represent SIG127 either as 0x7f represents a stopped
> >child.
> >
> >Therefore add sig_to_exitcode() and exitcode_to_sig() functions which
> >map signal numbers > 126 to exit code 126 and puts the remainder (i.e.
> >sig - 126) in higher bits. This allows WIFSIGNALED() to return true for
> >both SIG127 and SIG128, and allows WTERMSIG to be later updated to read
> >the correct signal number for SIG127 and SIG128.
> 
> I really hate this approach.
> 
> Can we just change the ABI to reduce the number of signals so that
> all the standard C library wait related macros don't have to be
> changed?

Changing the ABI is a very strong medicine that wants to be used very
carefully.

> Think about it, any user space program using signal numbers 127 and
> 128 doesn't work correctly as things exist today, so removing those
> two will be no great loss.

Glibc has it's own sigset_t of 1024 signals.  I wonder if it will even
use more than 64 signals.  Similar for other libcs.

  Ralf
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/