linux-kernel - Re: [PATCH v4] clocksource:arm_global_timer: Add ARM global timer support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Jun 2013 14:07:50 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>,
	John Stultz <john.stultz@...aro.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Stephen Gallimore <stephen.gallimore@...com>,
	Stuart Menefy <stuart.menefy@...com>,
	Rob Herring <robherring2@...il.com>,
	Will Deacon <will.deacon@....com>
Subject: Re: [PATCH v4] clocksource:arm_global_timer: Add ARM global timer
 support.

On 06/21/13 14:00, Thomas Gleixner wrote:
> On Fri, 21 Jun 2013, Stephen Boyd wrote:
>
>> On 06/21/13 08:56, Thomas Gleixner wrote:
>>>> +static irqreturn_t gt_clockevent_interrupt(int irq, void *dev_id)
>>>> +{
>>>> +	struct clock_event_device *evt = *(struct clock_event_device **)dev_id;
>>> What kind of construct is this?
>>>
>>> You are using request_percpu_irq() and the device id is pointing to
>>> per cpu memory. Why do you need this horrible pointer indirection?
>>>
>>> Because a lot of other ARM code uses the same broken construct?
>> This is an artifact of the ARM local timer API. I have been trying for a
> No, it's not an artifact. It's a copy and paste issue. Looking at
> drivers/clocksource/arm_arch_timer.c
>
>         arch_timer_evt = alloc_percpu(struct clock_event_device);
> ...
> 	err = request_percpu_irq(ppi, arch_timer_handler_virt,
>                                  "arch_timer", arch_timer_evt);
>
> This code is correct and it does not need any of the changes.
>
> Doing it with the pointer madness is just wrong, nothing else. Even if
> there is a historic reason why the pointer juggling was necessary at
> some point, it's obviously not needed anymore.
>
> And historic crap is no justification for brainlessly copied code.

The arm architected timers do not use the ARM local timer API anymore.
So yes that code is correct now that it has been moved off the local
timer API. See commit 1ba1cefc277865a0ac222f53bbbf2ebacad1559a for more
info.

Please merge my patches so the ARM local timer API can go away.

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/