| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 22 Jun 2013 12:50:59 +0800
From: Fengguang Wu <fengguang.wu@...el.com>
To: fengguang.wu@...el.com, Hans Verkuil <hans.verkuil@...co.com>
Cc: Mauro Carvalho Chehab <mchehab@...hat.com>,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: WARNING: at drivers/media/v4l2-core/v4l2-dev.c:775
__video_register_device()
Greetings,
I got the below dmesg and the first bad commit is
commit 1c1d86a1ea07506c070cfb217a009d53990bdeb0
Author: Hans Verkuil <hans.verkuil@...co.com>
Date: Wed Jun 12 11:15:12 2013 -0300
[media] v4l2: always require v4l2_dev, rename parent to dev_parent
The last set of drivers still using the parent field of video_device instead
of the v4l2_dev field have been converted, so v4l2_dev is now always set.
A proper pointer to v4l2_dev is necessary these days otherwise the advanced
debugging ioctls will not work when addressing sub-devices. It also ensures
that the core can always go from a video_device struct to the top-level
v4l2_device struct.
There is still one single use case for the parent pointer: if there are
multiple busses, each being the parent of one or more video nodes, and if
they all share the same v4l2_device struct. In that case one still needs a
parent pointer since the v4l2_device struct can only refer to a single
parent device. The cx88 driver is one such case. Unfortunately, the cx88
failed to set the parent pointer since 3.6. The next patch will correct this.
In order to support this use-case the parent pointer is only renamed to
dev_parent, not removed altogether. It has been renamed to ensure that the
compiler will catch any (possibly out-of-tree) drivers that were missed during
the conversion.
Signed-off-by: Hans Verkuil <hans.verkuil@...co.com>
Acked-by: Sakari Ailus <sakari.ailus@....fi>
Acked-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>
[ 1.957979] saa7164 driver loaded
[ 1.958709] ------------[ cut here ]------------
[ 1.959906] WARNING: at /c/kernel-tests/src/linux/drivers/media/v4l2-core/v4l2-dev.c:775 __video_register_device+0x3e/0xa52()
[ 1.961759] Modules linked in:
[ 1.962425] CPU: 0 PID: 1 Comm: swapper Not tainted 3.10.0-rc6-00397-gee17608 #195
[ 1.963644] Hardware name: Bochs Bochs, BIOS Bochs 01/01/2011
[ 1.964500] 00000000 00000000 cbc41e7c c188483c cbc41ea4 c102730d c1b44f8b c1c4b838
[ 1.966278] 00000307 c16b4e93 c16b4e93 cfa7d000 c1d431fc cfa6cfbc cbc41eb4 c10273a0
[ 1.968715] 00000009 00000000 cbc41f00 c16b4e93 c1042067 c13b2096 cbc40000 000080d0
[ 1.970530] Call Trace:
[ 1.971024] [<c188483c>] dump_stack+0x16/0x18
[ 1.971744] [<c102730d>] warn_slowpath_common+0x59/0x70
[ 1.972549] [<c16b4e93>] ? __video_register_device+0x3e/0xa52
[ 1.973420] [<c16b4e93>] ? __video_register_device+0x3e/0xa52
[ 1.974288] [<c10273a0>] warn_slowpath_null+0x1d/0x1f
[ 1.975074] [<c16b4e93>] __video_register_device+0x3e/0xa52
[ 1.975923] [<c1042067>] ? should_resched+0x8/0x22
[ 1.976695] [<c13b2096>] ? kzalloc.constprop.20+0xd/0xf
[ 1.977510] [<c13b2096>] ? kzalloc.constprop.20+0xd/0xf
[ 1.978309] [<c13b272c>] ? device_private_init+0x2c/0x44
[ 1.979116] [<c16f0930>] fm_v4l2_init_video_device+0x7f/0x1e6
[ 1.979983] [<c1d9e6f5>] fm_drv_init+0x65/0xa8
[ 1.980724] [<c1d9e690>] ? tea5764_i2c_driver_init+0x11/0x11
[ 1.981574] [<c1d9e690>] ? tea5764_i2c_driver_init+0x11/0x11
[ 1.982430] [<c10001ba>] do_one_initcall+0xab/0x13c
[ 1.983188] [<c1d6fa60>] kernel_init_freeable+0x11c/0x1ae
[ 1.984038] [<c1d6f416>] ? do_early_param+0x78/0x78
[ 1.984811] [<c187dc7a>] kernel_init+0xb/0xc3
[ 1.985717] [<c188f457>] ret_from_kernel_thread+0x1b/0x28
[ 1.987043] [<c187dc6f>] ? rest_init+0x6e/0x6e
[ 1.988220] ---[ end trace 188c81b2775d51cc ]---
git bisect start ee17608d6aa04a86e253a9130d6c6d00892f132b 756e6e14484b3249dad9663ed1398711b62676a3 --
git bisect good 20b4fb485227404329e41ad15588afad3df23050 # 10:45 20+ Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
git bisect good a8c4b90e670be3b01e9395c7310639c8109fc77e # 10:52 20+ Merge tag 'soc-for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
git bisect good 2c5f81d29c946165ae01c15e70b1bf2e16929009 # 10:59 20+ [media] drivers/media/pci/dm1105/dm1105: Convert to module_pci_driver
git bisect good 11e7064f35bb87da8f427d1aa4bbd8b7473a3993 # 11:20 20+ ALSA: usb-audio - Fix invalid volume resolution on Logitech HD webcam c270
git bisect good 17d8dfcda6ce570ddc4844f490104fed4af215aa # 11:32 20+ Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu
git bisect good 509768f751986f171710319f44170e7dbab37394 # 11:38 20+ Merge tag 'asoc-v3.10-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound
git bisect good f93f0b9cf7c6056ebeb844ed68a8e44888fffa05 # 11:43 20+ Merge tag 'clk-fixes-for-linus' of git://git.linaro.org/people/mturquette/linux
git bisect good 12869145718571ffa4f6e650a6f759934eeca0d9 # 11:47 20+ [media] v4l2-int-device: remove unused chip_ident reference
git bisect bad d9ec089ef248064ec9b3d027ed707ac6e0a3f2aa # 11:49 0- [media] radio-sf16fmi: Set frequency during init
git bisect bad e5715cfb2802cb5988f856f84454645772f4e2f5 # 11:50 0- [media] cx88: set dev_parent to the correct parent PCI bus
git bisect good 9592bd0a9e74c344f674663137e5ccff7a39f7d0 # 11:59 20+ [media] zoran: use v4l2_dev instead of the deprecated parent field
git bisect good b60f9aa1a9fcf69df963c1f06ee0594d836f6760 # 12:01 20+ [media] f_uvc: add v4l2_device and replace parent with v4l2_dev
git bisect good d481c581dfe43be11a17728b5c84c2d4b5beecb2 # 12:03 20+ [media] saa7134: use v4l2_dev instead of the deprecated parent field
git bisect bad 1c1d86a1ea07506c070cfb217a009d53990bdeb0 # 12:05 0- [media] v4l2: always require v4l2_dev, rename parent to dev_parent
git bisect good d481c581dfe43be11a17728b5c84c2d4b5beecb2 # 12:06 60+ [media] saa7134: use v4l2_dev instead of the deprecated parent field
git bisect bad ee17608d6aa04a86e253a9130d6c6d00892f132b # 12:06 0- [media] imx074: support asynchronous probing
git bisect good 73a8bd91a4401df1be4b044f89629ac06e2d6e36 # 12:08 60+ Revert "[media] v4l2: always require v4l2_dev, rename parent to dev_parent"
git bisect good f71194a7d47c1da787555d27aac63973ca72323b # 12:10 60+ Merge branch 'x86/urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect good e1a86578747376f08985627c84df088a5d0d1e92 # 12:12 60+ Add linux-next specific files for 20130621
Thanks,
Fengguang
View attachment "dmesg-kvm-cairo-13988-20130622035009-3.10.0-rc6-00397-gee17608-195" of type "text/plain" (32337 bytes)
View attachment "bisect-ee17608d6aa04a86e253a9130d6c6d00892f132b-i386-randconfig-r07-0621-__video_register_device-37904.log" of type "text/plain" (20411 bytes)
View attachment ".config-bisect" of type "text/plain" (99435 bytes)
Powered by blists - more mailing lists