linux-kernel - Re: [PATCH] iommu: Use %zx instead %lx and cast to unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 23 Jun 2013 21:14:36 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Joerg Roedel <joro@...tes.org>,
	Alex Williamson <alex.williamson@...hat.com>,
	iommu@...ts.linux-foundation.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iommu: Use %zx instead %lx and cast to unsigned long

On Sun, Jun 23, 2013 at 7:43 PM, Joe Perches <joe@...ches.com> wrote:
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -807,20 +807,19 @@ int iommu_map(struct iommu_domain *domain, unsigned long iova,
>          * size of the smallest page supported by the hardware
>          */
>         if (!IS_ALIGNED(iova | paddr | size, min_pagesz)) {
> -               pr_err("unaligned: iova 0x%lx pa 0x%lx size 0x%lx min_pagesz "
> -                       "0x%x\n", iova, (unsigned long)paddr,
> -                       (unsigned long)size, min_pagesz);
> +               pr_err("unaligned: iova 0x%lx pa 0x%lx size 0x%zx min_pagesz 0x%x\n",
> +                      iova, (unsigned long)paddr, size, min_pagesz);

While we're at it, paddr is phys_addr_t (which can be 32-bit or 64-bit),
so it should be cast to unsigned long long (instead of unsigned long),
and printed using %llx (instead of %lx).

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/