linux-kernel - Re: [PATCH V2] iommu: Use %pa and %zx instead of casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWHGmVpaqzMr9WZ++S9KcU=XL1c2Jdb7vDFxPD7=jbidg@mail.gmail.com>
Date:	Sun, 23 Jun 2013 21:38:48 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Joerg Roedel <joro@...tes.org>,
	Alex Williamson <alex.williamson@...hat.com>,
	iommu@...ts.linux-foundation.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] iommu: Use %pa and %zx instead of casting

On Sun, Jun 23, 2013 at 9:29 PM, Joe Perches <joe@...ches.com> wrote:
>> While we're at it, paddr is phys_addr_t (which can be 32-bit or 64-bit),
>> so it should be cast to unsigned long long (instead of unsigned long),
>> and printed using %llx (instead of %lx).
>
> Sounds good to me, except using %pa instead is better still.

Thanks, you're right. Still not used to this newish %pa...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/