linux-kernel - Re: [PATCH] scripts/setlocalversion on write-protected source tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130623221055.GA16118@pobox.suse.cz>
Date:	Mon, 24 Jun 2013 00:10:55 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Christian Kujau <lists@...dbynature.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	nico-linuxsetlocalversion@...ottelius.org
Subject: Re: [PATCH] scripts/setlocalversion on write-protected source tree

On Fri, Jun 14, 2013 at 06:04:34PM -0700, Christian Kujau wrote:
> I just stumbled across another[0] issue when scripts/setlocalversion 
> operates on a write-protected source tree. Back then[0] the source tree 
> was on an read-only NFS share, so "test -w" was introduced before "git 
> update-index" was run.
> 
> This time, the source tree is on read/write NFS share, but the permissions 
> are world-readable and only a specific user (or root) can write. 
> Thus, "test -w ." returns "0" and then runs "git update-index", 
> producing the following message (on a dirty tree):
> 
>   fatal: Unable to create '/usr/local/src/linux-git/.git/index.lock': Permission denied
> 
> While it says "fatal", compilation continues just fine.
> 
> However, I don't think a kernel compilation should alter the source 
> tree (or the .git directory) in any way and I don't see how removing 
> "git update-index" could do any harm. The Mercurial and SVN routines in 
> scripts/setlocalversion don't have any tree-modifying commands, AFAICS. 
> So, maybe the patch below would be acceptable.

Applied to kbuild.git#kbuild.

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/