linux-kernel - Re: [PATCH] pinctrl: rockchip: Add missing irq_gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201306231026.29244.heiko@sntech.de>
Date:	Sun, 23 Jun 2013 10:26:28 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: rockchip: Add missing irq_gc_unlock() call before return error

Am Sonntag, 23. Juni 2013, 02:48:34 schrieb Axel Lin:
> Signed-off-by: Axel Lin <axel.lin@...ics.com>

Thanks for catching this glitch.

Acked-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/pinctrl/pinctrl-rockchip.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pinctrl/pinctrl-rockchip.c
> b/drivers/pinctrl/pinctrl-rockchip.c index 427564f..1eb5a2e 100644
> --- a/drivers/pinctrl/pinctrl-rockchip.c
> +++ b/drivers/pinctrl/pinctrl-rockchip.c
> @@ -1035,6 +1035,7 @@ static int rockchip_irq_set_type(struct irq_data *d,
> unsigned int type) polarity &= ~mask;
>  		break;
>  	default:
> +		irq_gc_unlock(gc);
>  		return -EINVAL;
>  	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/