linux-kernel - Re: [PATCH] x86, tboot: provide debugfs interfaces to access TXT log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 24 Jun 2013 10:56:00 +0800
From:	Ren Qiaowei <qiaowei.ren@...el.com>
To:	Joe Perches <joe@...ches.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org, Gang Wei <gang.wei@...el.com>
Subject: Re: [PATCH] x86, tboot: provide debugfs interfaces to access TXT
 log

On 06/23/2013 04:36 PM, Joe Perches wrote:
> On Sun, 2013-06-23 at 15:54 +0800, Qiaowei Ren wrote:
>> These logs come from tboot (Trusted Boot, an open source,
>> pre-kernel/VMM module that uses Intel TXT to perform a
>> measured and verified launch of an OS kernel/VMM.).
> []
>> diff --git a/arch/x86/kernel/tboot.c b/arch/x86/kernel/tboot.c
> []
>> +static struct tboot_log *get_log(void)
>> +{
>> +	struct tboot_log *log;
>> +
>> +	log = (struct tboot_log *)ioremap_nocache(TBOOT_SERIAL_LOG_ADDR,
>> +						  TBOOT_SERIAL_LOG_SIZE);
>
> You might want to fix the sparse errors.
>    CHECK   arch/x86/kernel/tboot.c
> arch/x86/kernel/tboot.c:362:16: warning: cast removes address space of expression
> arch/x86/kernel/tboot.c:368:25: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/tboot.c:368:25:    expected void volatile [noderef] <asn:2>*addr
> arch/x86/kernel/tboot.c:368:25:    got struct tboot_log *[assigned] log
> arch/x86/kernel/tboot.c:395:17: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/tboot.c:395:17:    expected void volatile [noderef] <asn:2>*addr
> arch/x86/kernel/tboot.c:395:17:    got struct tboot_log *[assigned] log
> arch/x86/kernel/tboot.c:479:16: warning: incorrect type in assignment (different address spaces)
> arch/x86/kernel/tboot.c:479:16:    expected void *config
> arch/x86/kernel/tboot.c:479:16:    got void [noderef] <asn:2>*
> arch/x86/kernel/tboot.c:485:19: warning: incorrect type in assignment (different address spaces)
> arch/x86/kernel/tboot.c:485:19:    expected void *heap_base
> arch/x86/kernel/tboot.c:485:19:    got void [noderef] <asn:2>*
> arch/x86/kernel/tboot.c:487:17: warning: incorrect type in argument 1 (different address spaces)
> arch/x86/kernel/tboot.c:487:17:    expected void volatile [noderef] <asn:2>*addr
> arch/x86/kernel/tboot.c:487:17:    got void *config
>
>
Well, I guess that I can use iomem related interface to fix these 
warnings caused by sparse.

Thanks,
Qiaowei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/