linux-kernel - [PATCH 5/6] xtensa: Flat DeviceTree copy not future-safe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 24 Jun 2013 19:55:59 +0400
From:	Max Filippov <jcmvbkbc@...il.com>
To:	Chris Zankel <chris@...kel.net>
Cc:	Marc Gauthier <marc@...silica.com>, linux-xtensa@...ux-xtensa.org,
	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Vineet Gupta <vgupta@...opsys.com>,
	Max Filippov <jcmvbkbc@...il.com>, linux-kernel@...r.kernel.org
Subject: [PATCH 5/6] xtensa: Flat DeviceTree copy not future-safe

From: Vineet Gupta <Vineet.Gupta1@...opsys.com>

flat DT copy code calls bootmem allocator with @align = 0.
This is probably OK with legacy allocator which xtensa uses right now,
but this will panic right away with memblock allocator

Signed-off-by: Vineet Gupta <vgupta@...opsys.com>
Cc: Chris Zankel <chris@...kel.net>
Cc: Max Filippov <jcmvbkbc@...il.com>
Cc: Marc Gauthier <marc@...silica.com>
Cc: linux-xtensa@...ux-xtensa.org
Cc: linux-kernel@...r.kernel.org
Acked-by: Max Filippov <jcmvbkbc@...il.com>
Signed-off-by: Max Filippov <jcmvbkbc@...il.com>
---
 arch/xtensa/kernel/setup.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/xtensa/kernel/setup.c b/arch/xtensa/kernel/setup.c
index 14c6c3a..42a8bba 100644
--- a/arch/xtensa/kernel/setup.c
+++ b/arch/xtensa/kernel/setup.c
@@ -256,7 +256,7 @@ void __init early_init_devtree(void *params)
 static void __init copy_devtree(void)
 {
 	void *alloc = early_init_dt_alloc_memory_arch(
-			be32_to_cpu(initial_boot_params->totalsize), 0);
+			be32_to_cpu(initial_boot_params->totalsize), 8);
 	if (alloc) {
 		memcpy(alloc, initial_boot_params,
 				be32_to_cpu(initial_boot_params->totalsize));
-- 
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/