linux-kernel - Re: [PATCH RESEND v2 2/2] scsi: 64-bit port of buslogic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130624210747.GA19721@redhat.com>
Date:	Mon, 24 Jun 2013 17:07:47 -0400
From:	Dave Jones <davej@...hat.com>
To:	Khalid Aziz <khalid.aziz@...cle.com>
Cc:	James.Bottomley@...senPartnership.com, linux-scsi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Khalid Aziz <khalid@...ehiking.org>
Subject: Re: [PATCH RESEND v2 2/2] scsi: 64-bit port of buslogic driver

On Mon, Jun 24, 2013 at 02:26:00PM -0600, Khalid Aziz wrote:

 > @@ -821,7 +821,7 @@ struct blogic_ccb {
 >  	unsigned char cdblen;				/* Byte 2 */
 >  	unsigned char sense_datalen;			/* Byte 3 */
 >  	u32 datalen;					/* Bytes 4-7 */
 > -	u32 data;					/* Bytes 8-11 */
 > +	void *data;					/* Bytes 8-11 */

The comment (and subsequent ones for this struct)  are now wrong on 64-bit.
More of a concern though is that above this struct is this...

/*
  Define the 32 Bit Mode Command Control Block (CCB) structure.  The first 40
  bytes are defined by and common to both the MultiMaster Firmware and the
  FlashPoint SCCB Manager.


Is it safe to change this if the firmware/3rd party sw is expecting it to be a u32 ?

	Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/