linux-kernel - Re: [PATCH] misc/bmp085: Enable building as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130625072728.GB24258@scully.xfiles.lan>
Date:	Tue, 25 Jun 2013 09:27:28 +0200
From:	Eric Andersson <eric.andersson@...xphere.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc/bmp085: Enable building as a module

On 15:10 Mon 24 Jun     , Ben Hutchings wrote:
> Commit 985087dbcb02 'misc: add support for bmp18x chips to the bmp085
> driver' changed the BMP085 config symbol to a boolean.  I see no
> reason why the shared code cannot be built as a module, so change it
> back to tristate.
> 
> Cc: Eric Andersson <eric.andersson@...xphere.com>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  drivers/misc/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index c002d86..7a68184 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -451,7 +451,7 @@ config ARM_CHARLCD
>  	  still useful.
>  
>  config BMP085
> -	bool
> +	tristate
>  	depends on SYSFS
>  
>  config BMP085_I2C
> 

There is no reason for building the common code stand-alone. The BMP085
config option is only selectable via the BMP085_I2C/_SPI options.
See the select-statement for those options:

 config BMP085_I2C
	tristate "BMP085 digital pressure sensor on I2C"
	select BMP085
 ...

-- 
Best regards,
 Eric

 http://www.unixphere.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/