linux-kernel - Re: [PATCH V3] irqchip: Add TB10x interrupt controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 25 Jun 2013 14:33:02 +0100
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Christian Ruppert <christian.ruppert@...lis.com>
Cc:	Vineet Gupta <Vineet.Gupta1@...opsys.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	devicetree-discuss <devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Pierrick Hascoet <pierrick.hascoet@...lis.com>
Subject: Re: [PATCH V3] irqchip: Add TB10x interrupt controller driver

On Tue, Jun 25, 2013 at 2:29 PM, Christian Ruppert
<christian.ruppert@...lis.com> wrote:
> On Mon, Jun 03, 2013 at 10:51:06AM +0100, Grant Likely wrote:
>> On Mon, Jun 3, 2013 at 5:05 AM, Vineet Gupta <Vineet.Gupta1@...opsys.com> wrote:
>> > On 06/01/2013 03:48 AM, Grant Likely wrote:
>> >> If I were working on this system I'd drop the
>> >> snps,arc700-intc node entirely and have a single abilis,tb10x-intc that
>> >> encapsulated the properties of both (you would of course want to share
>> >> handler functions for the 'normal' inputs without the custom features).
>> >> That would eliminate the goofyness of listing 27 separate interrupts in
>> >> the abilis,tb10x-ictl interrupts property.
>> >
>> > But how is this different from other systems with a primary in-core intc and a
>> > cascaded external intc. How do they do it. I guess I need to read up more on this.
>>
>> Usually cascaded irq controllers have multiple irqs multiplexed onto a
>> single irq on the parent controller. It's the 1:1 situation that makes
>> this controller odd.
>
> You're right, this might be a bit confusing. The controller was mainly
> designed as a compatibility layer between ARC770 built-in interrupts and
> the rest of the system.
>
> Do you see a better way to drive this kind of hardware? Do you have any
> other comments on the driver?
>
> Without this driver, arch/arc/plat-tb10x and related drivers will not
> work and it would thus be good to have this in the kernel as quickly as
> possible if there are no more issues with it.

No, I don't have any other issues with it. It is unconventional, but
the framework handles it fine the way you've set it up.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/