linux-kernel - Re: [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51C9A992.7010209@windriver.com>
Date:	Tue, 25 Jun 2013 10:30:42 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	<linux-kernel@...r.kernel.org>, "Rafael J. Wysocki" <rjw@...k.pl>,
	<cpufreq@...r.kernel.org>, <linux-pm@...r.kernel.org>
Subject: Re: [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq
 files

On 13-06-24 11:31 PM, Viresh Kumar wrote:
> On 25 June 2013 01:00, Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
> 
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>> index f8c2860..5687d28 100644
>> --- a/drivers/cpufreq/cpufreq.c
>> +++ b/drivers/cpufreq/cpufreq.c
>> @@ -1900,8 +1900,8 @@ no_policy:
>>  }
>>  EXPORT_SYMBOL(cpufreq_update_policy);
>>
>> -static int __cpuinit cpufreq_cpu_callback(struct notifier_block *nfb,
>> -                                       unsigned long action, void *hcpu)
>> +static int cpufreq_cpu_callback(struct notifier_block *nfb,
>> +                               unsigned long action, void *hcpu)
> 
> You were not required to change second line here and also don't
> change its indentation level. Check this everywhere.
> 

[...]

Since you've explicitly requested it, I've left all second lines
of args untouched in v2, now pushed to the patch queue:

http://git.kernel.org/cgit/linux/kernel/git/paulg/cpuinit-delete.git

> 
> Fix these and add my
> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
> 
> Probably this can go through Rafael's pm tree. So, you can take it
> out of this series if you want.

I'd encourage people to not take the patches into their specific
trees unless they really feel a specific need to do so.  It will
keep the majority of them clumped together in git history that way.

Thanks,
Paul.
--

> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/