linux-kernel - Re: [PATCH] staging: usbip: replace pr_warning() with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130625145428.GA19101@kroah.com>
Date:	Tue, 25 Jun 2013 07:54:28 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	navin patidar <navinp@...c.in>
Cc:	mfm@...eddisk.com, linux-usb@...r.kernel.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: usbip: replace pr_warning() with pr_warn()

On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote:
> On Tue, Jun 25, 2013, Greg KH <gregkh@...uxfoundation.org> said:
> 
> > On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote:
> >> pr_warn() is preferred over pr_warning().
> >
> > And dev_warn() is preferred over both of them, can you convert the code
> > to use that instead?
> >
> 
> struct device is not available in usbip_start_eh()  which is required
> for dev_warn().
> 
> usbip_device's containers struct stub_device and struct  vhci_device
> both have member structure usb_device but inside usbip_start_eh(), it
> is difficult to determine  to which container struct usbip_device
> belongs, thus container_of() can not be used here to get struct
> usb_device.

Then the code should be reworked in order to be able to properly
determine that.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/