linux-kernel - Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51C9B59A.6000407@wwwdotorg.org>
Date:	Tue, 25 Jun 2013 09:22:02 -0600
From:	Stephen Warren <swarren@...dotorg.org>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	Christian Ruppert <christian.ruppert@...lis.com>,
	Patrice CHOTARD <patrice.chotard@...com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	Sascha Leuenberger <sascha.leuenberger@...lis.com>,
	Pierrick Hascoet <pierrick.hascoet@...lis.com>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	Alexandre Courbot <acourbot@...dia.com>
Subject: Re: [PATCH 2/2] Make non-linear GPIO ranges accesible from gpiolib

On 06/25/2013 08:32 AM, Linus Walleij wrote:
> On Fri, Jun 21, 2013 at 11:17 PM, Stephen Warren <swarren@...dotorg.org> wrote:
>> On 06/20/2013 05:57 AM, Christian Ruppert wrote:
> 
>> The Linux pinctrl subsystem specifically doesn't provide mutual
>> exclusion between "mux function" and GPIO usage within a pin group,
>> although perhaps a driver could internally.
> 
> It used to block this at one point. But it doesn't make sense
> when the hardware looks like so:
> 
>>>                                                      +- SPI
>>>                  Physical pins --- GPIO --- pinctrl -+- I2C
>>>                                                      +- mmc
> 
> As in this case it is perfectly legal to enable the GPIO as
> input while the I2C bus is running and "spy" on the signals.
> 
> The driver should probably not allow the GPIO output to be
> driven while some peripheral is muxed in though, that could be
> disastrous...

Well, in the HW diagram above, GPIO output probably simply overrides
"mux function" output, so everything would work as requested. Whether it
makes sense to request such an override is a policy question that
pinctrl itself probably shouldn't decide. After all, what if there's a
pin group containing 4 pins, which are used by the board as 2 GPIO and 2
I2C. pinctrl shouldn't disallow selecting GPIO on any pin in that pin
group simply because I2C is selected on it; that fact doesn't
necessarily mean that the selected mux function actually uses every
single pin in the group.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/