linux-kernel - Re: [PATCH] staging: ozwpan: Convert printk to dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1372183005.1245.72.camel@joe-AO722>
Date:	Tue, 25 Jun 2013 10:56:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	Jason Baron <jbaron@...hat.com>, shigekatsu.tateno@...el.com,
	devel@...uxdriverproject.org, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ozwpan: Convert printk to dev_dbg()

On Tue, 2013-06-25 at 10:38 -0700, Greg KH wrote:
> On Tue, Jun 25, 2013 at 10:29:50AM -0700, Joe Perches wrote:
> > a long needed extension to dev_dbg is to enable classes
> > of messages by level or mask.
> > 
> > There are many existing macros like
> > 
> > #define module_dbg(level, fmt, ...)
> > do {
> > 	if (level >= some_module_var)
> > 		debug_something(...);
> > } while (0)
> > 
> > and
> > 
> > #define module_dbg(mask, fmt, ...)
> > do {
> > 	if (mask & some_module_var)
> > 		debug_something(...)
> > } while (0)
> > 
> > It'd be nice to consolidate those in dev_dbg
> 
> I'd almost recommend that all of them just be removed, because most of
> them were only used for debugging the code the first time it was
> developed, right?  Only for very limited usages would this type of thing
> be needed.

Maybe, though that's hard to know with certainty.
How often module options are used isn't easy to find out.

These forms are sometimes used to reduce object size.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/