linux-kernel - Re: [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1372133724.1245.38.camel@joe-AO722>
Date:	Mon, 24 Jun 2013 21:15:24 -0700
From:	Joe Perches <joe@...ches.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	cpufreq@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH 25/32] cpufreq: delete __cpuinit usage from all cpufreq
 files

On Tue, 2013-06-25 at 09:01 +0530, Viresh Kumar wrote:
> On 25 June 2013 01:00, Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
[]
> > -static int __cpuinit cpufreq_cpu_callback(struct notifier_block *nfb,
> > -                                       unsigned long action, void *hcpu)
> > +static int cpufreq_cpu_callback(struct notifier_block *nfb,
> > +                               unsigned long action, void *hcpu)
> 
> You were not required to change second line here and also don't
> change its indentation level. Check this everywhere.

Paul, yes, thanks for doing that here,
but please, do it everywhere...

;)

> > diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
[]
> > @@ -306,7 +306,7 @@ static int cpufreq_stat_notifier_policy(struct notifier_block *nb,
> >  }
> >
> >  static int cpufreq_stat_notifier_trans(struct notifier_block *nb,
> > -               unsigned long val, void *data)
> > +                                      unsigned long val, void *data)
> 
> See.. unnecessary change.

Or from another perspective, ideal change.

> > -static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
> > +static int cpufreq_stat_cpu_callback(struct notifier_block *nfb,
> >                                                unsigned long action,
> >                                                void *hcpu)

Hey Paul, you missed some too.

Viresh, there's no absolute "right" way to do this.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/