linux-kernel - Re: [PATCH 29/32] rcu: delete __cpuinit usage from all rcu files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130625193237.GF3828@linux.vnet.ibm.com>
Date:	Tue, 25 Jun 2013 12:32:37 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Josh Triplett <josh@...edesktop.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	linux-kernel@...r.kernel.org, Dipankar Sarma <dipankar@...ibm.com>
Subject: Re: [PATCH 29/32] rcu: delete __cpuinit usage from all rcu files

On Mon, Jun 24, 2013 at 06:10:46PM -0700, Josh Triplett wrote:
> On Mon, Jun 24, 2013 at 03:30:34PM -0400, Paul Gortmaker wrote:
> > The __cpuinit type of throwaway sections might have made sense
> > some time ago when RAM was more constrained, but now the savings
> > do not offset the cost and complications.  For example, the fix in
> > commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
> > is a good example of the nasty type of bugs that can be created
> > with improper use of the various __init prefixes.
> > 
> > After a discussion on LKML[1] it was decided that cpuinit should go
> > the way of devinit and be phased out.  Once all the users are gone,
> > we can then finally remove the macros themselves from linux/init.h.
> > 
> > This removes all the drivers/rcu uses of the __cpuinit macros
> > from all C files.
> > 
> > [1] https://lkml.org/lkml/2013/5/20/589
> > 
> > Cc: "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
> > Cc: Josh Triplett <josh@...edesktop.org>
> > Cc: Dipankar Sarma <dipankar@...ibm.com>
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> > ---
> 
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Queued for 3.12 with Josh's Reviewed-by.  Thank you both!

							Thanx, Paul

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/