linux-kernel - Re: [tip:x86/asm] x86, processor-flags: Fix the datatypes and add bit number defines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51CA240C.4000407@zytor.com>
Date:	Tue, 25 Jun 2013 16:13:16 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Borislav Petkov <bp@...en8.de>
CC:	mingo@...nel.org, linux-kernel@...r.kernel.org,
	torvalds@...ux-foundation.org, tglx@...utronix.de,
	hpa@...ux.intel.com, linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/asm] x86, processor-flags: Fix the datatypes and add
 bit number defines

On 06/25/2013 04:07 PM, Borislav Petkov wrote:
> 
> Btw, are you going to need those _BIT defines anywhere else?
> 
> Because if no, you could simply do:
> 
> #define X86_EFLAGS_CF		_BITUL(0) /* Carry Flag */
> 
> and so on, and drop the _BIT defines.
> 

Yes.  I didn't get around to doing this particular bit of the cleanup,
but we have several places where we currently index various bits by
open-coded numbers, especially in assembly code.

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/