linux-kernel - Re: [PATCH net] tun: fix recovery from gup errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130625.162429.966445706450575614.davem@davemloft.net>
Date:	Tue, 25 Jun 2013 16:24:29 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	jasowang@...hat.com
Cc:	mst@...hat.com, linux-kernel@...r.kernel.org, edumazet@...gle.com,
	nhorman@...driver.com, netdev@...r.kernel.org, bhubbard@...hat.com
Subject: Re: [PATCH net] tun: fix recovery from gup errors

From: Jason Wang <jasowang@...hat.com>
Date: Mon, 24 Jun 2013 11:22:52 +0800

> On 06/23/2013 10:19 PM, Michael S. Tsirkin wrote:
>> get user pages might fail partially in tun zero copy
>> mode. To recover we need to put all pages that we got,
>> but code used a wrong index resulting in double-free
>> errors.
>>
>> Reported-by: Brad Hubbard <bhubbard@...hat.com>
>> Signed-off-by: Michael S. Tsirkin <mst@...hat.com>
>> ---
>>
>> I haven't figured out why do we get failures,
>> but recovery is clearly wrong.
>>
>> This is also -stable material.
> 
> Acked-by: Jason Wang <jasowang@...hat.com>

Applied with the missing empty line added, I was tired of waiting for
Michael to take care of this himself.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/