linux-kernel - Re: [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err call in wmt_pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Jun 2013 17:38:55 +1200
From:	Tony Prisk <linux@...sktech.co.nz>
To:	Wei Yongjun <weiyj.lk@...il.com>
CC:	linus.walleij@...aro.org, axel.lin@...ics.com,
	maxime.ripard@...e-electrons.com, swarren@...dia.com,
	yongjun_wei@...ndmicro.com.cn, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] pinctrl: vt8500: wmt: remove redundant dev_err
 call in wmt_pinctrl_probe()

On 26/06/13 13:56, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> ---
>   drivers/pinctrl/vt8500/pinctrl-wmt.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> index fb30edf3..0cc4335 100644
> --- a/drivers/pinctrl/vt8500/pinctrl-wmt.c
> +++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> @@ -570,10 +570,8 @@ int wmt_pinctrl_probe(struct platform_device *pdev,
>   
>   	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>   	data->base = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(data->base)) {
> -		dev_err(&pdev->dev, "failed to map memory resource\n");
> +	if (IS_ERR(data->base))
>   		return PTR_ERR(data->base);
> -	}
>   
>   	wmt_desc.pins = data->pins;
>   	wmt_desc.npins = data->npins;
Acked-by: Tony Prisk <linux@...sktech.co.nz>

Regards
Tony P
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/