| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAPV97yd6tZDs17cQb+3x0YpjnfOqnv=oRg-2w2hBTFpoHjxzEg@mail.gmail.com> Date: Wed, 26 Jun 2013 11:27:23 +0530 From: navin patidar <navinp@...c.in> To: Greg KH <gregkh@...uxfoundation.org> Cc: mfm@...eddisk.com, linux-usb@...r.kernel.org, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: On Tue, Jun 25, 2013, Greg KH <gregkh@...uxfoundation.org> said: > On Tue, Jun 25, 2013 at 04:27:18PM +0530, navin patidar wrote: >> On Tue, Jun 25, 2013, Greg KH <gregkh@...uxfoundation.org> said: >> >> > On Fri, Jun 21, 2013 at 03:01:04PM +0530, navin patidar wrote: >> >> pr_warn() is preferred over pr_warning(). >> > >> > And dev_warn() is preferred over both of them, can you convert the code >> > to use that instead? >> > >> >> struct device is not available in usbip_start_eh() which is required >> for dev_warn(). >> >> usbip_device's containers struct stub_device and struct vhci_device >> both have member structure usb_device but inside usbip_start_eh(), it >> is difficult to determine to which container struct usbip_device >> belongs, thus container_of() can not be used here to get struct >> usb_device. > > Then the code should be reworked in order to be able to properly > determine that. How about adding a usb_device pointer in usbip_device structure ? regards, --navin-patidar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists