linux-kernel - Re: [PATCH v1 3/3] usb: musb: dsps: handle babble condition for dsps platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130626082956.GO12640@arwen.pp.htv.fi>
Date:	Wed, 26 Jun 2013 11:29:56 +0300
From:	Felipe Balbi <balbi@...com>
To:	Ravi Babu <ravibabu@...com>
CC:	<linux-usb@...r.kernel.org>, <balbi@...com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 3/3] usb: musb: dsps: handle babble condition for dsps
 platform

Hi,

On Wed, May 29, 2013 at 06:37:04PM +0530, Ravi Babu wrote:
> @@ -428,6 +436,29 @@ static int dsps_musb_exit(struct musb *musb)
>  	return 0;
>  }
>  
> +static void dsps_musb_restart(struct musb *musb)
> +{
> +	struct device *dev = musb->controller;
> +	struct dsps_glue *glue = dev_get_drvdata(dev->parent);
> +	const struct dsps_musb_wrapper *wrp = glue->wrp;
> +	void __iomem *reg_base = musb->ctrl_base;
> +
> +	/* Reset the musb */
> +	dsps_writel(reg_base, wrp->control, (1 << wrp->reset));
> +	udelay(100);
> +
> +	/* Stop the on-chip PHY and its PLL. */
> +	usb_phy_vbus_off(musb->xceiv);
> +	udelay(100);
> +
> +	/* Start the on-chip PHY and its PLL. */
> +	usb_phy_vbus_on(musb->xceiv);
> +	udelay(100);
> +
> +	/* reinit the endpoint fifo table and restart musb */
> +	musb_restart(musb);

everything here, except for the glue reset, is generic. The thing is
that I don't really think the IP needs to be reset to recover from
babble.

Babble is a valid error condition, it's not even fatal right.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)