linux-kernel - Re: [16/26] r8169: fix 8168evl frame padding.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51CAAB98.6040706@canonical.com>
Date:	Wed, 26 Jun 2013 10:51:36 +0200
From:	Stefan Bader <stefan.bader@...onical.com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	akpm@...ux-foundation.org, hayeswang <hayeswang@...ltek.com>,
	Francois Romieu <romieu@...zoreil.com>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [16/26] r8169: fix 8168evl frame padding.

On 26.06.2013 04:35, Ben Hutchings wrote:
> 3.2.48-rc1 review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Stefan Bader <stefan.bader@...onical.com>
> 
> [ Upstream commits e5195c1f31f399289347e043d6abf3ffa80f0005 and
>   b423e9ae49d78ea3f53b131c8d5a6087aed16fd6 ]
> 
> Signed-off-by: Stefan Bader <stefan.bader@...onical.com>
> Acked-by: Francois Romieu <romieu@...zoreil.com>
> Cc: hayeswang <hayeswang@...ltek.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
> ---
>  drivers/net/ethernet/realtek/r8169.c | 33 +++++++++++++++++++++++++++------

No abjection, just make sure that

commit b423e9ae49d78ea3f53b131c8d5a6087aed16fd6
Author: françois romieu <romieu@...zoreil.com>
Date:   Sat May 18 01:24:46 2013 +0000

    r8169: fix offloaded tx checksum for small packets.

    8168evl offloaded checksums are wrong since commit
    e5195c1f31f399289347e043d6abf3ffa80f0005 ("r8169: fix 8168evl frame padding.
    pads small packets to 60 bytes (without ethernet checksum). Typical symptoms
    appear as UDP checksums which are wrong by the count of added bytes.

    It isn't worth compensating. Let the driver checksum.

    Due to the skb length changes, TSO code is moved before the Tx descriptor ge
    written.

    Signed-off-by: Francois Romieu <romieu@...zoreil.com>
    Tested-by: Holger Hoffstätte <holger.hoffstaette@...glemail.com>
    Signed-off-by: David S. Miller <davem@...emloft.net>

is included as well.

-Stefan


Download attachment "signature.asc" of type "application/pgp-signature" (900 bytes)