linux-kernel - Re: [PATCH] arch/arc: angel4.dts - add description for "arc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51CAB760.3050008@synopsys.com>
Date:	Wed, 26 Jun 2013 15:11:52 +0530
From:	Vineet Gupta <Vineet.Gupta1@...opsys.com>
To:	Alexey Brodkin <Alexey.Brodkin@...opsys.com>
CC:	<netdev@...r.kernel.org>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Francois Romieu <romieu@...zoreil.com>,
	Joe Perches <joe@...ches.com>,
	Mischa Jonker <Mischa.Jonker@...opsys.com>,
	Arnd Bergmann <arnd@...db.de>,
	"Grant Likely" <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	"David S. Miller" <davem@...emloft.net>,
	<linux-kernel@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>,
	Florian Fainelli <florian@...nwrt.org>
Subject: Re: [PATCH] arch/arc: angel4.dts - add description for "arc_emac"

On 06/26/2013 03:07 PM, Alexey Brodkin wrote:
> With this patch we introduce DT "arc_emac" description for ARCangel4.
> Description is based on info/example in
> "Documentation/devicetree/bindings/net/arc_emac.txt".
>
> Signed-off-by: Alexey Brodkin <abrodkin@...opsys.com>
>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Francois Romieu <romieu@...zoreil.com>
> Cc: Joe Perches <joe@...ches.com>
> Cc: Vineet Gupta <vgupta@...opsys.com>
> Cc: Mischa Jonker <mjonker@...opsys.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Grant Likely <grant.likely@...aro.org>
> Cc: Rob Herring <rob.herring@...xeda.com>
> Cc: Paul Gortmaker <paul.gortmaker@...driver.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: linux-kernel@...r.kernel.org
> Cc: devicetree-discuss@...ts.ozlabs.org
> Cc: Florian Fainelli <florian@...nwrt.org>
> ---
>  arch/arc/boot/dts/angel4.dts |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>
> diff --git a/arch/arc/boot/dts/angel4.dts b/arch/arc/boot/dts/angel4.dts
> index bae4f93..4fb2d6f 100644
> --- a/arch/arc/boot/dts/angel4.dts
> +++ b/arch/arc/boot/dts/angel4.dts
> @@ -51,5 +51,21 @@
>  			current-speed = <115200>;
>  			status = "okay";
>  		};
> +
> +		ethernet@...c2000 {
> +			compatible = "snps,arc-emac";
> +			reg = <0xc0fc2000 0x3c>;
> +			interrupts = <6>;
> +			mac-address = [ 00 11 22 33 44 55 ];
> +			clock-frequency = <80000000>;
> +			max-speed = <100>;
> +			phy = <&phy0>;
> +
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			phy0: ethernet-phy@0 {
> +				reg = <1>;
> +			};
> +		};
>  	};
>  };

This looks good - for completeness sake, can you also send a patch to remove
legacy hardcodings for irq/mem-map from arch/arc/plat-arcfpga/include/*

-Vineet
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/