linux-kernel - Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined pstore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51CAC127.8070106@linux.vnet.ibm.com>
Date:	Wed, 26 Jun 2013 15:53:35 +0530
From:	Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>
To:	Tony Luck <tony.luck@...il.com>
CC:	Kees Cook <keescook@...omium.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>, ananth@...ibm.com,
	mahesh@...ux.vnet.ibm.com,
	Anton Vorontsov <cbouatmailru@...il.com>,
	Colin Cross <ccross@...roid.com>
Subject: Re: [PATCH v2] pstore: Fail to unlink if a driver has not defined
 pstore_erase

On Tuesday 25 June 2013 10:40 PM, Tony Luck wrote:
> On Tue, Jun 25, 2013 at 9:41 AM, Kees Cook <keescook@...omium.org> wrote:
>> On Tue, Jun 25, 2013 at 2:03 AM, Aruna Balakrishnaiah
>> <aruna@...ux.vnet.ibm.com> wrote:
>>> pstore_erase is used to erase the record from the persistent store.
>>> So if a driver has not defined pstore_erase callback return
> How do people manage devices like this?  With no erase function
> they just keep getting more and more pstore entries. Eventually
> they fill up.

We dont keep old records in the device. We have logs only of the
recent / last crash.  The device has a predefined space for each type
of messages.  For example:  Every time a crash occurs the data gets
overwritten in the device allocated to store crash log.

>
>>> Signed-off-by: Aruna Balakrishnaiah <aruna@...ux.vnet.ibm.com>
>> Acked-by: Kees Cook <keescook@...omium.org>
> Applied - thanks.
>
> -Tony
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/