linux-kernel - Re: [PATCH 2/2] video:da8xx-fb: Convert to devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51CAD7E4.2000403@ti.com>
Date:	Wed, 26 Jun 2013 15:00:36 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Prabhakar Lad <prabhakar.csengg@...il.com>
CC:	"Etheridge, Darren" <detheridge@...com>,
	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	LFBDEV <linux-fbdev@...r.kernel.org>,
	Florian Tobias Schandinat <FlorianSchandinat@....de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] video:da8xx-fb: Convert to devm_* api

On 26/06/13 14:56, Prabhakar Lad wrote:
> Hi Tomi,
> 
> On Wed, Jun 26, 2013 at 5:09 PM, Tomi Valkeinen <tomi.valkeinen@...com> wrote:
>> On 16/05/13 10:10, Lad Prabhakar wrote:
>>> From: Lad, Prabhakar <prabhakar.csengg@...il.com>
>>>
>>> Use devm_ioremap_resource instead of reques_mem_region()/ioremap() and
>>> devm_request_irq() instead of request_irq().
>>>
>>> This ensures more consistent error values and simplifies error paths.
>>>
>>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
>>> ---
>>>  drivers/video/da8xx-fb.c |   39 +++++++--------------------------------
>>>  1 files changed, 7 insertions(+), 32 deletions(-)
>>
>> There's something similar in Darren's da8xx-fb series. Can you check if
>> there are differences?
>>
> I don't see similar changes in his patch series.

[PATCH 14/23] video: da8xx-fb: use devres

 Tomi



Download attachment "signature.asc" of type "application/pgp-signature" (902 bytes)