linux-kernel - Re: [PATCH v2] staging: usbip: replace pr_warning() with dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51CAE507.409@cogentembedded.com>
Date:	Wed, 26 Jun 2013 16:56:39 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	navin patidar <navinp@...c.in>
CC:	gregkh@...uxfoundation.org, mfm@...eddisk.com,
	linux-usb@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: usbip: replace pr_warning() with dev_warn().

Hello.

On 26-06-2013 13:41, navin patidar wrote:

> dev_warn() is preferred over pr_warning().

> container_of() is used to get usb_driver pointer from usbip_device container
> (stub_device or vhci_device), to get device structure required for dev_warn().

> Signed-off-by: navin patidar <navinp@...c.in>
> ---
>   drivers/staging/usbip/usbip_event.c |   14 +++++++++++++-
>   1 file changed, 13 insertions(+), 1 deletion(-)

> diff --git a/drivers/staging/usbip/usbip_event.c b/drivers/staging/usbip/usbip_event.c
> index 82123be..3bd1b94 100644
> --- a/drivers/staging/usbip/usbip_event.c
> +++ b/drivers/staging/usbip/usbip_event.c
> @@ -21,6 +21,8 @@
>   #include <linux/export.h>
>
>   #include "usbip_common.h"
> +#include "stub.h"
> +#include "vhci.h"
>
>   static int event_handler(struct usbip_device *ud)
>   {
> @@ -85,7 +87,17 @@ int usbip_start_eh(struct usbip_device *ud)
>
>   	ud->eh = kthread_run(event_handler_loop, ud, "usbip_eh");
>   	if (IS_ERR(ud->eh)) {
> -		pr_warning("Unable to start control thread\n");
> +		struct device dev;

    Empty line after declaration wouldn't hurt here...

> +		if (ud->side == USBIP_STUB) {
> +			struct stub_device *sdev;

    ... and here.

> +			sdev = container_of(ud, struct stub_device, ud);
> +			dev = sdev->udev->dev;
> +		} else {
> +			struct vhci_device *vdev;

    ... and here.

> +			vdev = container_of(ud, struct vhci_device, ud);
> +			dev = vdev->udev->dev;
> +		}
> +		dev_warn(&dev, "Unable to start control thread\n");

    Patch looks clumsy...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/