linux-kernel - Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace to oz

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1372256348.2076.11.camel@joe-AO722>
Date:	Wed, 26 Jun 2013 07:19:08 -0700
From:	Joe Perches <joe@...ches.com>
To:	Rupesh Gujare <rupesh.gujare@...el.com>
Cc:	shigekatsu.tateno@...el.com, Greg KH <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org
Subject: Re: [PATCH] staging: ozwpan: Use normal Makefile, convert oz_trace
 to oz_dbg

On Wed, 2013-06-26 at 06:56 -0700, Joe Perches wrote:
> On Wed, 2013-06-26 at 12:53 +0100, Rupesh Gujare wrote:
> > Above macros look good, however Greg have objection to define new macros 
> > & he had suggested to use dev_dbg() & pr_debug().

These macros already use pr_debug and should
use dev_dbg and netdev_dbg where appropriate
and possible.  These uses also don't depend
on a single saved global "struct device *".

The grouping/verbose flags are just as you
use them now, but a lot simpler and allow
an easy conversion to a runtime module_param.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/