linux-kernel - Re: [PATCH V3 0/2] x86/microcode/amd: early loading fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130626153706.GA8253@jshin-Toonie>
Date:	Wed, 26 Jun 2013 10:37:06 -0500
From:	Jacob Shin <jacob.shin@....com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	"H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Yinghai Lu <yinghai@...nel.org>,
	Henrique de Moraes Holschuh <hmh@....eng.br>,
	Borislav Petkov <bp@...en8.de>,
	Andreas Herrmann <herrmann.der.user@...glemail.com>,
	<x86@...nel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V3 0/2] x86/microcode/amd: early loading fixes

On Thu, Jun 20, 2013 at 10:24:14AM -0500, Jacob Shin wrote:
> On Thu, Jun 20, 2013 at 10:16:16AM -0500, Jacob Shin wrote:
> > On Thu, Jun 20, 2013 at 12:30:53PM +0200, Ingo Molnar wrote:
> > > 
> > > * Jacob Shin <jacob.shin@....com> wrote:
> > > 
> > > > On Fri, Jun 07, 2013 at 09:22:18PM -0500, Jacob Shin wrote:
> > > > > This patchset addreses two problems with early loading on AMD.
> > > > > 
> > > > > First, feedback from Yinghai that find_ucode_in_initrd() should be
> > > > > marked __init:
> > > > >   https://lkml.org/lkml/2013/6/4/695
> > > > > 
> > > > > And second, feedback from Henrique that Intel early loading supports
> > > > > multiple microcode firmware concatenated together, whereas the current
> > > > > AMD implementation lacks this support:
> > > > >   https://lkml.org/lkml/2013/5/31/4
> > > > > 
> > > > > V3:
> > > > > * style fix -- reduce multiple if statements into a single one
> > > > 
> > > > Hi hpa or Yinghai, just wondering if you had the chance to look at this
> > > > V3 yet.
> > > 
> > > It appears Peter applied v2 to tip:x86/microcode two days before you sent 
> > > v3 - please send any changes in v3 as delta patches.
> > 
> > I actually recieved the tip-bot email <https://lkml.org/lkml/2013/6/12/468>
> > couple of days after sending out the above message, so I assumed that
> > V3 was committed in.
> > 
> > I should have read the tip-bot message thoroughly and noticed
> > it. Sorry about that. Here is the delta patch:
> 
> Sigh :-( .. sorry, forgot to sign off. Here it is again:
> 
> ---8<---
> 
> From 1445587da716b306f39feef46fb7150f292060c7 Mon Sep 17 00:00:00 2001
> From: Jacob Shin <jacob.shin@....com>
> Date: Thu, 20 Jun 2013 09:52:50 -0500
> Subject: [PATCH] x86, microcode, amd: another early loading fixup
> 
> commit cd1c32ca969ebfd65e61312c988223bb14f09c2e is an early premature
> rendition of the patch. Augment it with this delta patch to:
>   * correctly mark offset and size of the matching bin file
>   * use __pa instead of __pa_nodebug during AP load
>   * check for !initrd_start before using it
> 
> Signed-off-by: Jacob Shin <jacob.shin@....com>

Hi hpa, checking back to see if you had the chance to look at this
delta patch. It is needed to properly support concatenated microcode
binaries on AMD early load. (Intel already supports this).

Thank you,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/