linux-kernel - Re: [PATCH 3/5] ARM: dts: am33xx: Add interrupts and memory resources for MMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51CB17F2.5060504@ti.com>
Date:	Wed, 26 Jun 2013 22:03:54 +0530
From:	Balaji T K <balajitk@...com>
To:	Joel A Fernandes <agnel.joel@...il.com>
CC:	Tony Lindgren <tony@...mide.com>, Sekhar Nori <nsekhar@...com>,
	Matt Porter <matt@...orter.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Vinod Koul <vinod.koul@...el.com>,
	Mark Brown <broonie@...aro.org>,
	Benoit Cousson <b-cousson@...com>,
	Russell King <linux@....linux.org.uk>,
	Rob Landley <rob@...dley.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jason Kridner <jkridner@...gleboard.org>,
	Koen Kooi <koen@...gleboard.org>, Chris Ball <cjb@...top.org>,
	Devicetree Discuss <devicetree-discuss@...ts.ozlabs.org>,
	Linux OMAP List <linux-omap@...r.kernel.org>,
	Linux ARM Kernel List <linux-arm-kernel@...ts.infradead.org>,
	Linux DaVinci Kernel List 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Documentation List <linux-doc@...r.kernel.org>,
	Linux MMC List <linux-mmc@...r.kernel.org>,
	Linux SPI Devel List 
	<spi-devel-general@...ts.sourceforge.net>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 3/5] ARM: dts: am33xx: Add interrupts and memory resources
 for MMC

Hi Joel,

On Wednesday 26 June 2013 06:54 AM, Joel A Fernandes wrote:
> From: Joel A Fernandes <agnel.joel@...il.com>
>
> HWMOD irq entries for MMC were removed. We provide the same from DT for MMC.
>
> This fixes issue where memory resource could not be found during probe.
> Also, added the reg-offset property to account for the offset from start.
>
> Signed-off-by: Joel A Fernandes <agnel.joel@...il.com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi |   12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 119f8a9..e0a5741 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -237,6 +237,10 @@
>   			dmas = <&edma 24
>   				&edma 25>;
>   			dma-names = "tx", "rx";
> +			interrupts = <64>;
> +			interrupt-parent = <&intc>;
> +			reg = <0x48060000 0x1000>;
> +			reg-offset = <0x100>;
>   			status = "disabled";
>   		};
>
> @@ -247,6 +251,10 @@
>   			dmas = <&edma 2
>   				&edma 3>;
>   			dma-names = "tx", "rx";
> +			interrupts = <24>;

s/24/28

> +			interrupt-parent = <&intc>;
> +			reg = <0x481d8000 0x1000>;
> +			reg-offset = <0x100>;
>   			status = "disabled";
>   		};
>
> @@ -254,6 +262,10 @@
>   			compatible = "ti,omap3-hsmmc";

compatible should be ti,omap4-hsmmc since omap4 hsmmc IP is re-used in am33xx
and reg-offset property is not needed.
combine this patch with 2/5 ARM: dts: add AM33XX MMC support and please add
your signed-off to that patch.

>   			ti,hwmods = "mmc3";
>   			ti,needs-special-reset;
> +			interrupts = <25>;

s/25/29

> +			interrupt-parent = <&intc>;
> +			reg = <0x47810000 0x1000>;
> +			reg-offset = <0x100>;
>   			status = "disabled";
>   		};
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/