linux-kernel - Re: [PATCH 12/15] perf tools: allow non-matching sample types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51CBF083.3060705@intel.com>
Date:	Thu, 27 Jun 2013 10:57:55 +0300
From:	Adrian Hunter <adrian.hunter@...el.com>
To:	Jiri Olsa <jolsa@...hat.com>
CC:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org, David Ahern <dsahern@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Namhyung Kim <namhyung@...il.com>,
	Paul Mackerras <paulus@...ba.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 12/15] perf tools: allow non-matching sample types

On 25/06/13 15:32, Jiri Olsa wrote:
> On Mon, Jun 24, 2013 at 04:16:09PM +0300, Adrian Hunter wrote:
>> Sample types need not be identical to determine
>> the sample id from the event.  Only the position
>> of the sample id needs to be the same.
>>
>> Compatible sample types are ones in which the bits
>> defined by PERF_COMPAT_MASK are the same.
>> 'perf_evlist__config()' forces sample types to be
>> compatible on that basis.
> 
> hi,
> one of the patches is breaking test 4:
> 
> [jolsa@...va perf]$ sudo ./perf test
>  1: vmlinux symtab matches kallsyms                        : Ok
>  2: detect open syscall event                              : Ok
>  3: detect open syscall event on all cpus                  : Ok
>  4: read samples using the mmap interface                  :Can't parse sample, err = -14
>  FAILED!
> 
> haven't checked deeply, but my guess is this one ;-)

Thanks for testing.  Fixed in V2.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/