linux-kernel - Re: [PATCH RESEND v2 2/2] scsi: 64-bit port of buslogic driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Jun 2013 18:34:39 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Khalid Aziz <khalid.aziz@...cle.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Khalid Aziz <khalid@...ehiking.org>
Subject: Re: [PATCH RESEND v2 2/2] scsi: 64-bit port of buslogic driver

On Mon, 2013-06-24 at 14:26 -0600, Khalid Aziz wrote: 
> @@ -5072,17 +5039,15 @@ static void FPT_busMstrSGDataXferStart(unsigned long p_port,
>   * Description: 
>   *
>   *---------------------------------------------------------------------*/
> -static void FPT_busMstrDataXferStart(unsigned long p_port,
> -				     struct sccb *pcurrSCCB)
> +static void FPT_busMstrDataXferStart(u32 p_port, struct sccb *pcurrSCCB)
>  {
> -	unsigned long addr, count;
> +	u32 addr, count;
>  
>  	if (!(pcurrSCCB->Sccb_XferState & F_AUTO_SENSE)) {
>  
>  		count = pcurrSCCB->Sccb_XferCnt;
>  
> -		addr =
> -		    (unsigned long)pcurrSCCB->DataPointer + pcurrSCCB->Sccb_ATC;
> +		addr = (u32)pcurrSCCB->DataPointer + pcurrSCCB->Sccb_ATC;

This is giving

In file included from drivers/scsi/BusLogic.c:57:0:
drivers/scsi/FlashPoint.c: In function ‘FPT_busMstrDataXferStart’:
drivers/scsi/FlashPoint.c:5050:10: warning: cast from pointer to integer
of different size [-Wpointer-to-int-cast]

to do this cast, you need first to cast to unsigned long and then
truncate the long with u32.  I fixed it up.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/