linux-kernel - RE: [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Jun 2013 11:50:05 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	James Bottomley <jbottomley@...allels.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"ohering@...e.com" <ohering@...e.com>,
	"hch@...radead.org" <hch@...radead.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel
 support



> -----Original Message-----
> From: James Bottomley [mailto:jbottomley@...allels.com]
> Sent: Wednesday, June 26, 2013 11:22 PM
> To: KY Srinivasan
> Cc: gregkh@...uxfoundation.org; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; ohering@...e.com; hch@...radead.org; linux-
> scsi@...r.kernel.org
> Subject: Re: [PATCH 3/5] Drivers: scsi: storvsc: Implement multi-channel support
> 
> On Tue, 2013-06-04 at 12:05 -0700, K. Y. Srinivasan wrote:
> > Implement multi-channel support for the storage devices.
> 
> This doesn't compile:
> 
>   CC [M]  drivers/scsi/storvsc_drv.o
> drivers/scsi/storvsc_drv.c: In function ‘handle_sc_creation’:
> drivers/scsi/storvsc_drv.c:763:35: error: ‘struct vmbus_channel’ has no
> member named ‘primary_channel’
> drivers/scsi/storvsc_drv.c: In function ‘handle_multichannel_storage’:
> drivers/scsi/storvsc_drv.c:805:2: error: implicit declaration of
> function
> ‘vmbus_set_sc_create_callback’ [-Werror=implicit-function-declaration]
> drivers/scsi/storvsc_drv.c:812:2: error: implicit declaration of
> function
> ‘vmbus_are_subchannels_present’ [-Werror=implicit-function-declaration]
> drivers/scsi/storvsc_drv.c: In function ‘storvsc_on_channel_callback’:
> drivers/scsi/storvsc_drv.c:1223:13: error: ‘struct vmbus_channel’ has no
> member named ‘primary_channel’
> drivers/scsi/storvsc_drv.c:1224:19: error: ‘struct vmbus_channel’ has no
> member named ‘primary_channel’
> drivers/scsi/storvsc_drv.c: In function ‘storvsc_do_io’:
> drivers/scsi/storvsc_drv.c:1341:2: error: implicit declaration of
> function
> ‘vmbus_get_outgoing_channel’ [-Werror=implicit-function-declaration]
> drivers/scsi/storvsc_drv.c:1341:19: warning: assignment makes pointer
> from integer without a cast [enabled by default]
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/scsi/storvsc_drv.o] Error 1
> 
> I assume this is a cross tree dependency?  What's the relevant branch I
> need?

You are right; Greg checked in the relevant patch sometime back:

git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-next branch.


Regards,

K. Y

> 
> James