linux-kernel - Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGo_u6qbt9dANgKq49xR=1qsCpUBhmVaPL4EK04XvTw+=4Z23g@mail.gmail.com>
Date:	Thu, 27 Jun 2013 08:15:49 -0500
From:	Nishanth Menon <nm@...com>
To:	Luciano Coelho <coelho@...com>
Cc:	grant.likely@...aro.org, rob.herring@...xeda.com,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	lkml <linux-kernel@...r.kernel.org>,
	linux-wireless@...r.kernel.org, Tony Lindgren <tony@...mide.com>,
	linux-omap <linux-omap@...r.kernel.org>,
	linux-arm@...r.kernel.org
Subject: Re: [PATCH] Documentation: dt: bindings: TI WiLink modules

On Thu, Jun 27, 2013 at 7:58 AM, Luciano Coelho <coelho@...com> wrote:
> On Thu, 2013-06-27 at 07:51 -0500, Nishanth Menon wrote:
>> On 11:47-20130627, Luciano Coelho wrote:
>> > (added mailing lists and everyone back to the thread)
>> >
>> > On Wed, 2013-06-26 at 23:38 -0500, Nishanth Menon wrote:
>> > > On 06/25/2013 03:35 AM, Luciano Coelho wrote:
>> > > > +Optional properties:
>> > > > +--------------------
>> > > > +
>> > > > +- refclock: the internal WLAN reference clock frequency (required for
>> > > > +  WiLink6 and WiLink7; not used for WiLink8).  Must be one of the
>> > > > +  following:
>> > > > +       0 = 19.2 MHz
>> > > > +       1 = 26.0 MHz
>> > > > +       2 = 38.4 MHz
>> > > > +       3 = 52.0 MHz
>> > > > +       4 = 38.4 MHz, XTAL
>> > > > +       5 = 26.0 MHz, XTAL
>> > > > +
>> > > > +- tcxoclock: the internal WLAN TCXO clock frequency (required for
>> > > > +  WiLink7 not used for WiLink6 and WiLink8).  Must be one of the
>> > > > +  following:
>> > > > +       0 = 19.200 MHz
>> > > > +       1 = 26.000 MHz
>> > > > +       2 = 38.400 MHz
>> > > > +       3 = 52.000 MHz
>> > > > +       4 = 16.368 MHz
>> > > > +       5 = 32.736 MHz
>> > > > +       6 = 16.800 MHz
>> > > > +       7 = 33.600 MHz
>> > > >
>> > > just a gentle query - why not use frequency itself here in Hz for
>> > > refclock and txoclk?
>> >
>> > I thought about using the actual frequencies, but I decided not to do
>> > so, because I'd have to convert them to these values anyway.  These
>> > values are used to configure the firmware and it uses these
>> > "enumerations".
>> Could we not hide this under preprocessor macros instead? just wondering
>> of txoclock = <6>; kind of usage.. easy to make mistakes and easier to
>> confuse a new reader :).
>
> Yes, I guess we could create some preprocessor macros for this.  But the
> documentation would remain the same.  I can't add preprocessor macros to
> the bindings documentation. ;)
>
> For the actual DTS files, I could add a wilink.dtsi with enumerations
> for these values so they could be used in the node definitions.  But I'm
> not sure it's going to be that valuable in the end.
The  way GPIO HIGH was defined might help to provide guidance I think :)

Regards,
NM
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/