linux-kernel - Re: [PATCH v6 2/5] kernel: missing include in cputime.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1306271542530.4782@kaball.uk.xensource.com>
Date:	Thu, 27 Jun 2013 15:43:35 +0100
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Ingo Molnar <mingo@...nel.org>
CC:	Peter Zijlstra <peterz@...radead.org>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	<xen-devel@...ts.xensource.com>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <konrad.wilk@...cle.com>,
	<catalin.marinas@....com>, <arnd@...db.de>, <olof@...om.net>,
	<linux@....linux.org.uk>, <Ian.Campbell@...rix.com>,
	<will.deacon@....com>, <marc.zyngier@....com>, <mingo@...hat.com>
Subject: Re: [PATCH v6 2/5] kernel: missing include in cputime.c

On Thu, 27 Jun 2013, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Thu, Jun 27, 2013 at 02:54:29PM +0100, Stefano Stabellini wrote:
> > > steal_account_process_tick calls paravirt_steal_clock, but paravirt.h is
> > > currently missing amoung the included header files.
> > > Add include asm/paravirt.h ifdef CONFIG_PARAVIRT.
> > > 
> > > Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> > > CC: mingo@...hat.com
> > > CC: peterz@...radead.org
> > > 
> > > Changes in v5:
> > > - add ifdef CONFIG_PARAVIRT.
> > > ---
> > >  kernel/sched/cputime.c |    4 +++-
> > >  1 files changed, 3 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> > > index cc2dc3ee..317a578 100644
> > > --- a/kernel/sched/cputime.c
> > > +++ b/kernel/sched/cputime.c
> > > @@ -5,7 +5,9 @@
> > >  #include <linux/static_key.h>
> > >  #include <linux/context_tracking.h>
> > >  #include "sched.h"
> > > -
> > > +#ifdef CONFIG_PARAVIRT
> > > +#include <asm/paravirt.h>
> > > +#endif
> > 
> > Why isn't that CONFIG stuff inside the header instead of around it?
> 
> Indeed.
> 
> Once that is fixed then the #ifdef around asm/paravirt.h in 
> kernel/sched/core.c could be removed as well.

Right, that should work.
I'll make the change and resend with an additional patch to remove the
ifdef in kernel/sched/core.c.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/