linux-kernel - Re: [PATCH] net: fec: Fix multicast list setup in fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <C2B6127F-2C6D-49ED-9E45-5FEE9CC1BCE4@theobroma-systems.com>
Date:	Thu, 27 Jun 2013 19:14:37 +0200
From:	Christoph Müllner 
	<christoph.muellner@...obroma-systems.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <rob.herring@...xeda.com>,
	"David S. Miller" <davem@...emloft.net>,
	Fabio Estevam <fabio.estevam@...escale.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: fec: Fix multicast list setup in fec_restart().

On Jun 21, 2013, at 7:15 PM, Fabio Estevam <festevam@...il.com> wrote:

> On Fri, Jun 21, 2013 at 1:40 PM, Christoph Müllner
> <christoph.muellner@...obroma-systems.com> wrote:
> 
>> @@ -472,8 +474,7 @@ fec_restart(struct net_device *ndev, int duplex)
>>        writel(0xffc00000, fep->hwp + FEC_IEVENT);
>> 
>>        /* Reset all multicast. */
> 
> Should this comment be removed/updated now?

Is updated in the attached patch.
Thank you for the feedback!

> 
>> -       writel(0, fep->hwp + FEC_GRP_HASH_TABLE_HIGH);
>> -       writel(0, fep->hwp + FEC_GRP_HASH_TABLE_LOW);
>> +       set_multicast_list(ndev);


Download attachment "0001-net-fec-Fix-multicast-list-setup-in-fec_restart.patch" of type "application/octet-stream" (1464 bytes)