linux-kernel - Re: [PATCH] ACPI/fan: Initialize acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1990033.Jb3giURhtn@vostro.rjw.lan>
Date:	Thu, 27 Jun 2013 21:29:39 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Naresh Bhat <naresh.bhat@...aro.org>
Cc:	linux-acpi@...r.kernel.org, len.brown@...el.com,
	patches@...aro.org, linaro-kernel@...ts.linaro.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ACPI/fan: Initialize acpi_state variable

On Thursday, June 27, 2013 06:37:35 PM Naresh Bhat wrote:
> Hi Rafael,
> 
> You mean I need to initialize using ACPI_STATE_D0 ? and resend the patch ?

Yes, please.

Although this is a false positive anyway ...

Thanks,
Rafael


> On 27 June 2013 17:58, Rafael J. Wysocki <rjw@...k.pl> wrote:
> > On Thursday, June 27, 2013 04:38:34 PM naresh.bhat@...aro.org wrote:
> >> From: Naresh Bhat <naresh.bhat@...aro.org>
> >>
> >>   CC      drivers/acpi/fan.o
> >> drivers/acpi/fan.c: In function ‘fan_get_cur_state’:
> >> drivers/acpi/fan.c:96:9: warning: ‘acpi_state’ may be used uninitialized in this function [-Wuninitialized]
> >> ---
> >>  drivers/acpi/fan.c |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/acpi/fan.c b/drivers/acpi/fan.c
> >> index f815da8..f61f7fd 100644
> >> --- a/drivers/acpi/fan.c
> >> +++ b/drivers/acpi/fan.c
> >> @@ -84,7 +84,7 @@ static int fan_get_cur_state(struct thermal_cooling_device *cdev, unsigned long
> >>  {
> >>       struct acpi_device *device = cdev->devdata;
> >>       int result;
> >> -     int acpi_state;
> >> +     int acpi_state = 0;
> >
> > Please use an appropriate symbol here.
> >
> >>
> >>       if (!device)
> >>               return -EINVAL;
> >>
> >
> > Thanks,
> > Rafael
> >
> >
> > --
> > I speak only for myself.
> > Rafael J. Wysocki, Intel Open Source Technology Center.
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/