linux-kernel - Re: [PATCH] arch: frv: mb93090-mb00: remove '__init' for pci_fixup_umc_ide() which used by 'DECLARE_PCI_FIXUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51CB85A2.9040207@asianux.com>
Date:	Thu, 27 Jun 2013 08:21:54 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
CC:	"dhowells@...hat.com" <dhowells@...hat.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Yinghai Lu <yinghai@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linux-Arch <linux-arch@...r.kernel.org>
Subject: Re: [PATCH] arch: frv: mb93090-mb00: remove '__init' for pci_fixup_umc_ide()
 which used by 'DECLARE_PCI_FIXUP_HEADER'

On 06/27/2013 12:19 AM, Bjorn Helgaas wrote:
> On Tue, Jun 25, 2013 at 8:55 PM, Chen Gang <gang.chen@...anux.com> wrote:
>> > pci_fixup_umc_ide() is for 'DECLARE_PCI_FIXUP_HEADER', so need remove
>> > it from init section to normal section.
>> >
>> > The related warning (with allmodconfig):
>> >
>> >   LD      arch/frv/mb93090-mb00/built-in.o
>> > WARNING: arch/frv/mb93090-mb00/built-in.o(.pci_fixup_header+0x4c): Section mismatch in reference from the variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide to the function .init.text:pci_fixup_umc_ide()
>> > The variable __pci_fixup_PCI_VENDOR_ID_UMCPCI_DEVICE_ID_UMC_UM8886BFpci_fixup_umc_ide references
>> > a function __init pci_fixup_umc_ide().
>> > This is often seen when error handling in the init function
>> > uses functionality in the exit path.
>> > The fix is often to remove the __init annotation of
>> > pci_fixup_umc_ide() so it may be used outside an exit section.
>> >
>> >
>> > Signed-off-by: Chen Gang <gang.chen@...anux.com>
> Reviewed-by: Bjorn Helgaas <bhelgaas@...gle.com>
> 

Thanks.

-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/